[PyTorch] Fix GIL/refcount abort in Comm+GEMM overlap and NCCL-EP init bindings - #3203
Merged
Merged
Conversation
Signed-off-by: Alp Dener <adener@nvidia.com>
Contributor
Greptile SummaryThis PR narrows where the PyTorch bindings release the GIL.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix GIL/refcount abort in Comm+GEMM over..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The factory
py::initbindings forCommOverlap/CommOverlapP2Pand theep_initializebinding were registered with an outerpy::call_guard<py::gil_scoped_release>(), which releases the GIL for the entire call -- including regions where pybind11 performs Python reference-count operations that require the GIL to be held. This triggers a pybind11 GIL/ref-count hazard assert when TE is compiled withNVTE_BUILD_DEBUG=1.PR fixes the bug by dropping the outer call guard and releasing the GIL narrowly, only around the blocking C++ native constructor/initializer. The GIL is reacquired before pybind11 casts the arguments, registers the holder and destroys the by-value object parameters.
Fixes # 3199
Type of change
Checklist: