Skip to content

Update list of authorized CI users - #3211

Merged
timmoon10 merged 1 commit into
NVIDIA:mainfrom
timmoon10:tmoon/update-ci-users
Jul 15, 2026
Merged

Update list of authorized CI users#3211
timmoon10 merged 1 commit into
NVIDIA:mainfrom
timmoon10:tmoon/update-ci-users

Conversation

@timmoon10

Copy link
Copy Markdown
Member

Description

@fheinecke @janekb04

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Update list of CI users

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added the testing Improvements to tests or testing infrastructure label Jul 14, 2026
@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the comment-triggered CI authorization list. The main changes are:

  • Adds fheinecke to the /te-ci authorized actor check.
  • Adds janekb04 to the /te-ci authorized actor check.

Confidence Score: 5/5

This looks safe to merge after checking the intended scope of the CI user list.

  • No blocking issues found in the changed workflow gate.
  • The only follow-up is whether the same users should be added to related comment-triggered CI allowlists.

.github/workflows/trigger-ci.yml

Important Files Changed

Filename Overview
.github/workflows/trigger-ci.yml Adds two actors to the existing /te-ci workflow authorization condition.

Reviews (1): Last reviewed commit: "Update list of authorized CI users" | Re-trigger Greptile

Comment on lines +63 to +64
|| github.actor == 'fheinecke'
|| github.actor == 'janekb04'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Split CI Allowlist State

If fheinecke and janekb04 are meant to be authorized CI users generally, this change only updates the /te-ci workflow. The sibling comment-triggered CI workflow keeps a separate allowlist, so the same users can trigger one CI path but still get rejected on the other.

@timmoon10
timmoon10 merged commit eabdd46 into NVIDIA:main Jul 15, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Improvements to tests or testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant