[Common] Ensure quantization kernels handle noop properly - #3271
Open
kainzhong wants to merge 1 commit into
Open
[Common] Ensure quantization kernels handle noop properly#3271kainzhong wants to merge 1 commit into
kainzhong wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryThe PR aligns noop handling across FP8, MXFP8, grouped MXFP8, and blockwise FP8 quantization.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the MXFP8 DBIAS path now passes a null noop pointer consistently to both quantization and padded-scale zeroing, so the previously reported stale-scale mismatch is fixed. Important Files Changed
Reviews (3): Last reviewed commit: "[Common] Ensure quantization kernels han..." | Re-trigger Greptile |
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
kainzhong
force-pushed
the
noop_tensor_fix
branch
from
August 5, 2026 22:41
456029e to
65ba3a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few places where quantization treats the noop flag wrong.
Type of change
Changes
Please list the changes introduced in this PR:
IS_DBIASsince the reduction kernel will run unconditionally, so if we skip quantization withIS_DBIASthe results would be wrong.zero_scales_kernelnow will ignore noop using the same condition as how the quantization ignores it (otherwise if we skip zeroing but not skip quantization the result could be wrong)group_block_scaled_1d_tma_kernelandgroup_block_scaled_2d_tma_kernelnow ignore the noop flag when dbias workspace is nullptr (I suppose this meansIS_DBIAS) for the same reasonChecklist: