[JAX] Migrate EP collective-stream annotation to compute_on2 - #3304
Open
phu0ngng wants to merge 1 commit into
Open
[JAX] Migrate EP collective-stream annotation to compute_on2#3304phu0ngng wants to merge 1 commit into
phu0ngng wants to merge 1 commit into
Conversation
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Collaborator
Author
|
Pipeline #60891724 with the nightly JAX image. |
Contributor
Greptile SummaryMigrates JAX expert-parallel collective-stream annotation from the removed
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The implementation preserves the compatibility fallback and the updated distributed compilation test exercises the new wrapper while checking that all emitted EP custom calls remain under collective-stream-annotated computations. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[EP helper invocation] --> B[Nullary thunk captures static config and array operands]
B --> C[compute_on2 collective-stream annotation]
C --> D[XLA async wrapper]
D --> E[EP FFI custom call]
F[HLO regression test] --> G[Parse computations and call edges]
G --> H[Verify each EP call is reachable from an annotated wrapper]
H --> E
Reviews (1): Last reviewed commit: "[JAX] Migrate EP collective-stream annot..." | Re-trigger Greptile |
jberchtold-nvidia
approved these changes
Aug 3, 2026
jberchtold-nvidia
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent JAX removed
jax.experimental.compute_on.compute_onin favor ofcompute_on2, breaking theimportofep.py(the annotation decorates EP helpers at module load). This migrates tocompute_on2.Type of change
Changes
_on_collective_streamusescompute_on2, closing over the staticEpLayerConfig/PartitionSpecargs in a nullary thunk sincecompute_on2abstract-evals every argument.compute_on2moves_xla_stream_annotationonto the async wrapper XLA generates, sotest_z_dispatch_combine_on_collective_streamnow checks each EP call is reachable from a collective-annotated wrapper.compute_on2andjax.memory.Spaceexist since JAX 0.10.1, the current collective-stream floor, so no min-version bump is needed.Checklist: