Skip to content

Pin nltk to work around breaking change in tests - #3306

Merged
ptrendx merged 1 commit into
NVIDIA:mainfrom
fheinecke:fred/pin-nltk-3.10.0
Aug 3, 2026
Merged

Pin nltk to work around breaking change in tests#3306
ptrendx merged 1 commit into
NVIDIA:mainfrom
fheinecke:fred/pin-nltk-3.10.0

Conversation

@fheinecke

@fheinecke fheinecke commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

JAX nightly tests are failing because TE tests install an unpinned dependency (nltk), which pushed a breaking change on Saturday. This limits the dependency to 3.10.0 or earlier. The change can be reverted after an upstream fix PR is merged.

This was not caught in the TE nightly tests because these create the test container in a slightly different way. Because TE tests set --container-workdir=/opt/transformerengine/qa/L0_jax_distributed_unittest, the nltk bug happens to not be hit.

Eventually we probably want to start pinning these test dependencies to remove this class of bug. Pinning to a specific checksum would make the root cause much more obvious.

See nvbug 6553963

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Fix new nltk version breaking JAX nightly tests

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Pins the NLTK test dependency below the upstream breaking release while retaining the existing minimum version.

  • Adds nltk<3.10.1 to the L0 JAX unit-test setup.
  • Applies the same temporary constraint to the L2 JAX unit-test setup.

Confidence Score: 5/5

The PR appears safe to merge and applies the intended temporary dependency constraint consistently across the affected JAX unit-test jobs.

The changed package specifications remain valid, preserve the prior minimum version, and exclude the upstream release identified as breaking these test paths.

Important Files Changed

Filename Overview
qa/L0_jax_unittest/test.sh Narrows the accepted NLTK range to prevent the affected JAX unit-test job from installing version 3.10.1 or newer.
qa/L2_jax_unittest/test.sh Applies the same compatible NLTK range to the L2 JAX unit-test job.

Reviews (1): Last reviewed commit: "Pin nltk to work around breaking change ..." | Re-trigger Greptile

@fheinecke

Copy link
Copy Markdown
Collaborator Author

/te-ci

@ptrendx
ptrendx merged commit cb7e2de into NVIDIA:main Aug 3, 2026
31 of 36 checks passed
KshitijLakhani pushed a commit that referenced this pull request Aug 4, 2026
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants