Pin nltk to work around breaking change in tests - #3306
Merged
Conversation
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Contributor
Greptile SummaryPins the NLTK test dependency below the upstream breaking release while retaining the existing minimum version.
Confidence Score: 5/5The PR appears safe to merge and applies the intended temporary dependency constraint consistently across the affected JAX unit-test jobs. The changed package specifications remain valid, preserve the prior minimum version, and exclude the upstream release identified as breaking these test paths. Important Files Changed
Reviews (1): Last reviewed commit: "Pin nltk to work around breaking change ..." | Re-trigger Greptile |
Collaborator
Author
|
/te-ci |
ptrendx
approved these changes
Aug 3, 2026
KshitijLakhani
pushed a commit
that referenced
this pull request
Aug 4, 2026
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JAX nightly tests are failing because TE tests install an unpinned dependency (nltk), which pushed a breaking change on Saturday. This limits the dependency to 3.10.0 or earlier. The change can be reverted after an upstream fix PR is merged.
This was not caught in the TE nightly tests because these create the test container in a slightly different way. Because TE tests set
--container-workdir=/opt/transformerengine/qa/L0_jax_distributed_unittest, the nltk bug happens to not be hit.Eventually we probably want to start pinning these test dependencies to remove this class of bug. Pinning to a specific checksum would make the root cause much more obvious.
See nvbug 6553963
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: