[BACKPORT] Implement math functions for thrust::complex#1191
Merged
jrhemstad merged 1 commit intoNVIDIA:branch/2.3.xfrom Dec 8, 2023
Merged
[BACKPORT] Implement math functions for thrust::complex#1191jrhemstad merged 1 commit intoNVIDIA:branch/2.3.xfrom
jrhemstad merged 1 commit intoNVIDIA:branch/2.3.xfrom
Conversation
* Implement math functions for `thrust::complex` We are having issues that the `cuda::std` math functions that take a `cuda::std::complex` return a `cuda::std::complex`. This can lead to issues as we require a conversion sequence from `cuda::std::complex` to `thrust::complex` which e.g is broken by an constructor being explicit. Addresses nvbug4397241
miscco
requested review from
alliepiper,
ericniebler,
gevtushenko and
jrhemstad
miscco
added
libcu++
gevtushenko
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #1178
We need to ensure that math functions that return a
complex<T>actually return athrust::complex<T>and not acuda::std::complex<T>