PTX: Add cuda::ptx:cp_async_bulk_*#1403
Merged
miscco merged 14 commits intoNVIDIA:mainfrom Feb 26, 2024
Merged
Conversation
Contributor
Author
|
Not sure if this is going to be caught by CI: the However, since we compile with Can we disable this behavior somehow in lit? @miscco |
miscco
reviewed
Feb 20, 2024
libcudacxx/test/libcudacxx/cuda/ptx/ptx.cp.reduce.async.bulk.tensor.compile.pass.cpp
Outdated
Show resolved
Hide resolved
ahendriksen
commented
Feb 20, 2024
Contributor
Author
ahendriksen
left a comment
There was a problem hiding this comment.
Thanks for the review! I have implemented most of the comments. One comment is addressed in #1359, and one comment (combining the ptx isa guards in the tests) I hope we can punt to a future PR.
libcudacxx/test/libcudacxx/cuda/ptx/ptx.cp.reduce.async.bulk.tensor.compile.pass.cpp
Outdated
Show resolved
Hide resolved
2819ca0 to
3c5f7de
Compare
Add: - cp.async.bulk - cp.async.bulk.tensor - cp.reduce.async.bulk.tensor - cp.async.bulk.wait_group - cp.async.bulk.commit_group -
3c5f7de to
2f2244f
Compare
miscco
approved these changes
Feb 23, 2024
This was referenced Feb 27, 2024
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Feb 29, 2024
Add: - cp.async.bulk - cp.async.bulk.tensor - cp.reduce.async.bulk.tensor - cp.async.bulk.wait_group - cp.async.bulk.commit_group - Co-authored-by: Jake Hemstad <jhemstad@nvidia.com> Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add:
Description
closes #1398, #1399, #1400, #1401, #1402
Checklist