Adds tests for large number of items for cub::DeviceSelect#1612
Merged
elstehle merged 7 commits intoNVIDIA:mainfrom Apr 14, 2024
Merged
Adds tests for large number of items for cub::DeviceSelect#1612elstehle merged 7 commits intoNVIDIA:mainfrom
cub::DeviceSelect#1612elstehle merged 7 commits intoNVIDIA:mainfrom
Conversation
alliepiper
approved these changes
Apr 11, 2024
Contributor
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
A couple minor suggestions inline.
Merging main into this should fix the CI issues as well.
gevtushenko
approved these changes
Apr 13, 2024
This was referenced Apr 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PR #1379, we consolidated
thrust::copy_ifto usecub::DeviceSelect. Along with that change, we made thrust to dispatch using offset types usingi64if the given number of items was exceedingINT_MAX.Testing for large number of items in
thrust::copy_ifhas been limited to some sanity tests.We want to have more elaborate test coverage by adding tests for large number of items to the CUB tests of
cub::DeviceSelect, since we have better testing infrastructure in CUB.This PR adds those tests.
Closes #1584
Checklist