[CUDAX] Add a global constexpr cudax::devices range for all devices in the system#2100
Merged
ericniebler merged 6 commits intoNVIDIA:mainfrom Aug 3, 2024
Merged
Conversation
Contributor
Contributor
Author
|
pre-commit.ci autofix |
Contributor
Author
|
/ok to test |
cudax::devices range for all devices in the system
pciolkosz
reviewed
Jul 30, 2024
pciolkosz
reviewed
Jul 30, 2024
Contributor
Author
|
/ok to test |
Contributor
🟩 CI finished in 2h 40m: Pass: 100%/56 | Total: 2h 34m | Avg: 2m 45s | Max: 11m 45s | Hits: 90%/2188
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| pycuda |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| +/- | pycuda |
🏃 Runner counts (total jobs: 56)
| # | Runner |
|---|---|
| 41 | linux-amd64-cpu16 |
| 9 | linux-amd64-gpu-v100-latest-1 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
miscco
requested changes
Jul 30, 2024
the number of cuda devices can be determined by calling `cuda::devices.size()`. `cuda::devices` is a range of `cuda::device` objects.
c9cac6e to
ac07613
Compare
pciolkosz
approved these changes
Jul 30, 2024
Contributor
🟨 CI finished in 5h 06m: Pass: 96%/56 | Total: 3h 13m | Avg: 3m 27s | Max: 10m 52s | Hits: 71%/2279
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| pycuda |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| +/- | pycuda |
🏃 Runner counts (total jobs: 56)
| # | Runner |
|---|---|
| 41 | linux-amd64-cpu16 |
| 9 | linux-amd64-gpu-v100-latest-1 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
miscco
reviewed
Jul 31, 2024
miscco
reviewed
Jul 31, 2024
miscco
reviewed
Jul 31, 2024
miscco
reviewed
Jul 31, 2024
Contributor
Author
|
i have updated this pr to make |
Contributor
🟨 CI finished in 2h 23m: Pass: 98%/56 | Total: 2h 36m | Avg: 2m 48s | Max: 11m 55s | Hits: 90%/2586
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| pycuda |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| +/- | pycuda |
🏃 Runner counts (total jobs: 56)
| # | Runner |
|---|---|
| 41 | linux-amd64-cpu16 |
| 9 | linux-amd64-gpu-v100-latest-1 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
miscco
approved these changes
Aug 2, 2024
jrhemstad
reviewed
Aug 2, 2024
| CUDAX_REQUIRE(0 == cudax::devices.end()[-1].get()); | ||
| } | ||
|
|
||
| try |
Collaborator
There was a problem hiding this comment.
catch2 has some native machinery for verifying an expression throws a specific exception: https://github.com/catchorg/Catch2/blob/devel/docs/assertions.md#exceptions
Contributor
🟩 CI finished in 3h 49m: Pass: 100%/56 | Total: 2h 35m | Avg: 2m 46s | Max: 11m 11s | Hits: 91%/2738
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| pycuda |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| +/- | pycuda |
🏃 Runner counts (total jobs: 56)
| # | Runner |
|---|---|
| 41 | linux-amd64-cpu16 |
| 9 | linux-amd64-gpu-v100-latest-1 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Aug 4, 2024
… in the system (NVIDIA#2100) * add `cuda::devices` vector the number of cuda devices can be determined by calling `cuda::devices.size()`. `cuda::devices` is a range of `cuda::device` objects.
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Aug 4, 2024
… in the system (NVIDIA#2100) * add `cuda::devices` vector the number of cuda devices can be determined by calling `cuda::devices.size()`. `cuda::devices` is a range of `cuda::device` objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a global constexpr range of
cudax::deviceobjects.cudax::devices[0]is the same ascudax::device(0). The number of cuda devices in the system can be obtained withcudax::devices.size().see [548fc5d] for the changes in only this PR. EDIT: i will rebase when #2084 is merged.
closes #2099
Checklist