Disable automatic header inclusion for clangd#3365
Merged
miscco merged 1 commit intoNVIDIA:mainfrom Mar 3, 2025
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
fba66d3 to
2e4ed35
Compare
Contributor
🟩 CI finished in 2h 06m: Pass: 100%/148 | Total: 1d 20h | Avg: 17m 54s | Max: 1h 26m | Hits: 544%/25112
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 148)
| # | Runner |
|---|---|
| 98 | linux-amd64-cpu16 |
| 23 | linux-amd64-gpu-v100-latest-1 |
| 16 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
Contributor
bernhardmgruber
left a comment
There was a problem hiding this comment.
I would like somebody else to share their opinion on this. CLion also adds headers for me and I find that convenient. If it guessed wrongly, I can fix it. We can also detect bad includes later during review as well.
bernhardmgruber
approved these changes
Mar 3, 2025
Contributor
I have fallen into this trap myself now and I think we should go forward with this change! |
This commonly silently adds wrong relative includes at the wrong places
2e4ed35 to
98268df
Compare
Contributor
🟩 CI finished in 1h 28m: Pass: 100%/162 | Total: 1d 04h | Avg: 10m 36s | Max: 52m 18s | Hits: 86%/249219
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 162)
| # | Runner |
|---|---|
| 111 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Apr 7, 2025
This commonly silently adds wrong relative includes at the wrong places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commonly silently adds wrong relative includes at the wrong places