Port cub::DeviceScan tests to catch2#347
Merged
elstehle merged 4 commits intoNVIDIA:mainfrom Aug 21, 2023
Merged
Conversation
elstehle
requested review from
gevtushenko and
griwes
and removed request for
a team
elstehle
added
cub
gevtushenko
approved these changes
Aug 16, 2023
Collaborator
gevtushenko
left a comment
gevtushenko
left a comment
There was a problem hiding this comment.
A few minor comments below.
gevtushenko
reviewed
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR partially addresses #85. It migrates tests for
DeviceScanalgorithms to Catch2.Checklist