Fix devcontainers' initializeCommand#3533
Merged
miscco merged 6 commits intoNVIDIA:mainfrom Feb 6, 2025
Merged
Conversation
bernhardmgruber
approved these changes
Jan 27, 2025
miscco
approved these changes
Jan 27, 2025
Contributor
🟨 CI finished in 2h 46m: Pass: 96%/157 | Total: 1d 13h | Avg: 14m 11s | Max: 1h 27m | Hits: 92%/226890
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 157)
| # | Runner |
|---|---|
| 110 | linux-amd64-cpu16 |
| 21 | linux-amd64-gpu-v100-latest-1 |
| 15 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
b44696e to
9024ec1
Compare
wmaxey
approved these changes
Jan 28, 2025
Contributor
🟨 CI finished in 1d 21h: Pass: 99%/156 | Total: 1d 11h | Avg: 13m 41s | Max: 1h 17m | Hits: 109%/235979
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 156)
| # | Runner |
|---|---|
| 110 | linux-amd64-cpu16 |
| 21 | linux-amd64-gpu-v100-latest-1 |
| 14 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
9024ec1 to
974fc23
Compare
Contributor
🟨 CI finished in 1h 26m: Pass: 99%/156 | Total: 1d 05h | Avg: 11m 11s | Max: 1h 15m | Hits: 113%/236502
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 156)
| # | Runner |
|---|---|
| 110 | linux-amd64-cpu16 |
| 14 | windows-amd64-cpu16 |
| 12 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
Contributor
🟩 CI finished in 2h 08m: Pass: 100%/156 | Total: 1d 05h | Avg: 11m 13s | Max: 1h 15m | Hits: 113%/238355
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 156)
| # | Runner |
|---|---|
| 110 | linux-amd64-cpu16 |
| 14 | windows-amd64-cpu16 |
| 12 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
alliepiper
reviewed
Jan 31, 2025
Contributor
alliepiper
left a comment
There was a problem hiding this comment.
And bumping the msvc versions, nice! That was on my todo list.
alliepiper
approved these changes
Jan 31, 2025
974fc23 to
9268596
Compare
Contributor
🟩 CI finished in 1h 55m: Pass: 100%/155 | Total: 1d 01h | Avg: 9m 54s | Max: 1h 18m | Hits: 128%/198404
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 155)
| # | Runner |
|---|---|
| 108 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
9268596 to
1901249
Compare
Contributor
🟨 CI finished in 1h 51m: Pass: 99%/155 | Total: 1d 08h | Avg: 12m 40s | Max: 1h 13m | Hits: 121%/198515
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 155)
| # | Runner |
|---|---|
| 108 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
c6d26cf to
0c8ca16
Compare
miscco
approved these changes
Feb 6, 2025
Contributor
🟩 CI finished in 1h 42m: Pass: 100%/155 | Total: 1d 07h | Avg: 12m 21s | Max: 1h 21m | Hits: 86%/241925
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 155)
| # | Runner |
|---|---|
| 108 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
initializeCommandshould not pass two arguments tobash -c.The array syntax treats each element as a separate argument, and
bash -conly executes the first argument in Linux. Maybe gitbash on Windows executes more, but this is why the docker volume isn't created in Linux or CI.This PR also switches from
xaver.clang-formattoseaube.clangformat, because the former hasn't been released in 5 years.xaver.clang-formatdoes not account for vscode-clangd's language identifier switch fromcudatocuda-cpp, whereasseaube.clangformatdoes.Checklist