Disable X86-64 detection macro for Arm64 emulation on MSVC#3540
Merged
fbusato merged 3 commits intoNVIDIA:mainfrom Jan 31, 2025
Merged
Disable X86-64 detection macro for Arm64 emulation on MSVC#3540fbusato merged 3 commits intoNVIDIA:mainfrom
fbusato merged 3 commits intoNVIDIA:mainfrom
Conversation
bernhardmgruber
approved these changes
Jan 27, 2025
miscco
approved these changes
Jan 27, 2025
Contributor
🟨 CI finished in 4h 14m: Pass: 96%/135 | Total: 1d 08h | Avg: 14m 38s | Max: 1h 14m | Hits: 68%/11394
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 135)
| # | Runner |
|---|---|
| 92 | linux-amd64-cpu16 |
| 17 | linux-amd64-gpu-v100-latest-1 |
| 15 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1-testing |
Contributor
|
Does this PR really need a backport to 2.8? The original PR #3237 wasn't backported either. |
Contributor
Author
|
you are right. It is not needed. |
wmaxey
approved these changes
Jan 29, 2025
Contributor
🟩 CI finished in 1h 35m: Pass: 100%/152 | Total: 1d 09h | Avg: 13m 19s | Max: 1h 16m | Hits: 228%/21667
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 152)
| # | Runner |
|---|---|
| 110 | linux-amd64-cpu16 |
| 14 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 8 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 1 | linux-amd64-gpu-h100-latest-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@davebayer found that X86-64 detection macro
_M_X64on Windows is enabled even if we are compiling Arm64 in emulation mode.see #3237 (comment).
This PR fixes the X86-64 detection macro behavior.