[CUB] Remove pre-c++17 conditions and code by fbusato · Pull Request #3684 · NVIDIA/cccl

fbusato · 2025-02-04T22:47:20Z

Sub-task of #3595

cub/examples/block/example_block_reduce_dyn_smem.cu

github-actions · 2025-02-05T01:07:23Z

🟩 CI finished in 1h 37m: Pass: 100%/90 | Total: 1d 16h | Avg: 27m 02s | Max: 1h 13m | Hits: 248%/12730

🟩 cub: Pass: 100%/44 | Total: 1d 05h | Avg: 40m 00s | Max: 1h 13m | Hits: 325%/3500

🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  1d 03h | Avg: 39m 51s | Max:  1h 13m | Hits: 325%/3500  
  🟩 arm64              Pass: 100%/2   | Total:  1h 26m | Avg: 43m 13s | Max: 43m 14s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  3h 41m | Avg: 44m 19s | Max:  1h 06m | Hits: 325%/875   
  🟩 12.5               Pass: 100%/2   | Total:  1h 54m | Avg: 57m 01s | Max:  1h 05m
  🟩 12.8               Pass: 100%/37  | Total: 23h 45m | Avg: 38m 30s | Max:  1h 13m | Hits: 325%/2625  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 45m | Avg: 52m 44s | Max: 54m 22s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  3h 41m | Avg: 44m 19s | Max:  1h 06m | Hits: 325%/875   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 54m | Avg: 57m 01s | Max:  1h 05m
  🟩 nvcc12.8           Pass: 100%/35  | Total: 21h 59m | Avg: 37m 42s | Max:  1h 13m | Hits: 325%/2625  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 45m | Avg: 52m 44s | Max: 54m 22s
  🟩 nvcc               Pass: 100%/42  | Total:  1d 03h | Avg: 39m 24s | Max:  1h 13m | Hits: 325%/3500  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total:  2h 35m | Avg: 38m 52s | Max: 40m 20s
  🟩 Clang15            Pass: 100%/2   | Total:  1h 17m | Avg: 38m 36s | Max: 39m 31s
  🟩 Clang16            Pass: 100%/2   | Total:  1h 15m | Avg: 37m 39s | Max: 37m 57s
  🟩 Clang17            Pass: 100%/2   | Total:  1h 18m | Avg: 39m 14s | Max: 39m 44s
  🟩 Clang18            Pass: 100%/7   | Total:  4h 34m | Avg: 39m 11s | Max: 54m 22s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 14m | Avg: 37m 16s | Max: 37m 38s
  🟩 GCC8               Pass: 100%/1   | Total: 38m 53s | Avg: 38m 53s | Max: 38m 53s
  🟩 GCC9               Pass: 100%/2   | Total:  1h 22m | Avg: 41m 03s | Max: 41m 20s
  🟩 GCC10              Pass: 100%/2   | Total:  1h 19m | Avg: 39m 52s | Max: 40m 15s
  🟩 GCC11              Pass: 100%/2   | Total:  1h 18m | Avg: 39m 28s | Max: 40m 09s
  🟩 GCC12              Pass: 100%/2   | Total:  1h 17m | Avg: 38m 48s | Max: 39m 28s
  🟩 GCC13              Pass: 100%/10  | Total:  4h 32m | Avg: 27m 16s | Max: 45m 56s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 08m | Hits: 325%/1750  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 26m | Avg:  1h 13m | Max:  1h 13m | Hits: 325%/1750  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 54m | Avg: 57m 01s | Max:  1h 05m
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total: 11h 00m | Avg: 38m 52s | Max: 54m 22s
  🟩 GCC                Pass: 100%/21  | Total: 11h 44m | Avg: 33m 33s | Max: 45m 56s
  🟩 MSVC               Pass: 100%/4   | Total:  4h 41m | Avg:  1h 10m | Max:  1h 13m | Hits: 325%/3500  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 54m | Avg: 57m 01s | Max:  1h 05m
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 27m 58s | Avg: 13m 59s | Max: 23m 39s
  🟩 rtx2080            Pass: 100%/34  | Total:  1d 01h | Avg: 44m 53s | Max:  1h 13m | Hits: 325%/3500  
  🟩 rtxa6000           Pass: 100%/8   | Total:  3h 26m | Avg: 25m 47s | Max: 41m 27s
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  1d 02h | Avg: 43m 32s | Max:  1h 13m | Hits: 325%/3500  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 21m 28s | Avg: 21m 28s | Max: 21m 28s
  🟩 GraphCapture       Pass: 100%/1   | Total: 16m 06s | Avg: 16m 06s | Max: 16m 06s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 11m | Avg: 23m 52s | Max: 25m 47s
  🟩 TestGPU            Pass: 100%/2   | Total: 40m 38s | Avg: 20m 19s | Max: 21m 13s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 27m 58s | Avg: 13m 59s | Max: 23m 39s
  🟩 90;90a;100         Pass: 100%/1   | Total: 45m 56s | Avg: 45m 56s | Max: 45m 56s
🟩 std
  🟩 17                 Pass: 100%/20  | Total: 15h 10m | Avg: 45m 31s | Max:  1h 13m | Hits: 325%/2625  
  🟩 20                 Pass: 100%/24  | Total: 14h 10m | Avg: 35m 25s | Max:  1h 12m | Hits: 324%/875

🟩 thrust: Pass: 100%/43 | Total: 10h 38m | Avg: 14m 51s | Max: 58m 44s | Hits: 219%/9230

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 14s | Avg:  8m 37s | Max: 11m 11s
🟩 cpu
  🟩 amd64              Pass: 100%/41  | Total: 10h 28m | Avg: 15m 19s | Max: 58m 44s | Hits: 219%/9230  
  🟩 arm64              Pass: 100%/2   | Total: 10m 04s | Avg:  5m 02s | Max:  5m 18s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 13m | Avg: 14m 45s | Max: 51m 53s | Hits: 183%/1846  
  🟩 12.5               Pass: 100%/2   | Total:  1h 28m | Avg: 44m 03s | Max: 58m 32s
  🟩 12.8               Pass: 100%/36  | Total:  7h 56m | Avg: 13m 14s | Max: 58m 44s | Hits: 228%/7384  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 25s | Avg:  5m 12s | Max:  5m 15s
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 13m | Avg: 14m 45s | Max: 51m 53s | Hits: 183%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 28m | Avg: 44m 03s | Max: 58m 32s
  🟩 nvcc12.8           Pass: 100%/34  | Total:  7h 46m | Avg: 13m 42s | Max: 58m 44s | Hits: 228%/7384  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 25s | Avg:  5m 12s | Max:  5m 15s
  🟩 nvcc               Pass: 100%/41  | Total: 10h 28m | Avg: 15m 19s | Max: 58m 44s | Hits: 219%/9230  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 32s | Avg:  5m 23s | Max:  5m 38s
  🟩 Clang15            Pass: 100%/2   | Total: 11m 23s | Avg:  5m 41s | Max:  5m 42s
  🟩 Clang16            Pass: 100%/2   | Total: 11m 58s | Avg:  5m 59s | Max:  6m 03s
  🟩 Clang17            Pass: 100%/2   | Total: 11m 45s | Avg:  5m 52s | Max:  5m 59s
  🟩 Clang18            Pass: 100%/7   | Total: 45m 58s | Avg:  6m 34s | Max: 10m 28s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 44s | Avg:  5m 52s | Max:  6m 14s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 54s | Avg:  5m 54s | Max:  5m 54s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 46s | Avg:  5m 53s | Max:  6m 21s
  🟩 GCC10              Pass: 100%/2   | Total: 12m 00s | Avg:  6m 00s | Max:  6m 09s
  🟩 GCC11              Pass: 100%/2   | Total: 40m 33s | Avg: 20m 16s | Max: 34m 31s
  🟩 GCC12              Pass: 100%/2   | Total: 12m 31s | Avg:  6m 15s | Max:  6m 27s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 39m | Avg: 12m 26s | Max: 50m 06s
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 46m | Avg: 53m 17s | Max: 54m 41s | Hits: 183%/3692  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 27m | Avg: 49m 09s | Max: 58m 44s | Hits: 243%/5538  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 28m | Avg: 44m 03s | Max: 58m 32s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 42m | Avg:  6m 02s | Max: 10m 28s
  🟩 GCC                Pass: 100%/19  | Total:  3h 13m | Avg: 10m 12s | Max: 50m 06s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 14m | Avg: 50m 48s | Max: 58m 44s | Hits: 219%/9230  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 28m | Avg: 44m 03s | Max: 58m 32s
🟩 gpu
  🟩 rtx2080            Pass: 100%/33  | Total:  7h 19m | Avg: 13m 19s | Max: 58m 32s | Hits: 183%/5538  
  🟩 rtx4090            Pass: 100%/10  | Total:  3h 19m | Avg: 19m 54s | Max: 58m 44s | Hits: 273%/3692  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  8h 37m | Avg: 13m 58s | Max: 58m 44s | Hits: 183%/7384  
  🟩 TestCPU            Pass: 100%/3   | Total: 49m 51s | Avg: 16m 37s | Max: 33m 34s | Hits: 365%/1846  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 11m | Avg: 23m 55s | Max: 50m 06s
🟩 sm
  🟩 90;90a;100         Pass: 100%/1   | Total:  6m 19s | Avg:  6m 19s | Max:  6m 19s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  5h 13m | Avg: 15m 39s | Max: 58m 32s | Hits: 183%/5538  
  🟩 20                 Pass: 100%/21  | Total:  5h 08m | Avg: 14m 40s | Max: 58m 44s | Hits: 273%/3692

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 01s | Avg: 4m 30s | Max: 6m 53s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  9m 01s | Avg:  4m 30s | Max:  6m 53s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 08s | Avg:  2m 08s | Max:  2m 08s
  🟩 Test               Pass: 100%/1   | Total:  6m 53s | Avg:  6m 53s | Max:  6m 53s

🟩 python: Pass: 100%/1 | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
	libcu++
+/-	CUB
+/-	Thrust
	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 90)

#	Runner
65	`linux-amd64-cpu16`
9	`windows-amd64-cpu16`
6	`linux-amd64-gpu-rtxa6000-latest-1`
4	`linux-arm64-cpu16`
3	`linux-amd64-gpu-rtx4090-latest-1`
2	`linux-amd64-gpu-rtx2080-latest-1`
1	`linux-amd64-gpu-h100-latest-1`

remove pre-c++17 conditions and code

544c464

fbusato added the 3.0 label Feb 4, 2025

fbusato self-assigned this Feb 4, 2025

fbusato requested review from a team as code owners February 4, 2025 22:47

fbusato requested review from gevtushenko and wmaxey February 4, 2025 22:47

bernhardmgruber approved these changes Feb 4, 2025

View reviewed changes

cub/examples/block/example_block_reduce_dyn_smem.cu Outdated Show resolved Hide resolved

fbusato added 3 commits February 4, 2025 15:26

remove IGNORE_DEPRECATED_CPP11/14_DIALECT from build target list

3fd9fc6

update compiler flag

c4ff0ec

replace NVTX3_CONSTEXPR_IF_CPP14 with constexpr

e8f2fd0

fbusato requested a review from a team as a code owner February 4, 2025 23:27

fbusato enabled auto-merge (squash) February 4, 2025 23:28

fbusato merged commit e9dbf6f into NVIDIA:main Feb 5, 2025
101 of 104 checks passed

fbusato deleted the remove-pre-cpp-17-from-cub branch February 11, 2025 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CUB] Remove pre-c++17 conditions and code#3684

[CUB] Remove pre-c++17 conditions and code#3684
fbusato merged 4 commits intoNVIDIA:mainfrom
fbusato:remove-pre-cpp-17-from-cub

fbusato commented Feb 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2025

🟩 cub: Pass: 100%/44 | Total: 1d 05h | Avg: 40m 00s | Max: 1h 13m | Hits: 325%/3500

🟩 thrust: Pass: 100%/43 | Total: 10h 38m | Avg: 14m 51s | Max: 58m 44s | Hits: 219%/9230

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 01s | Avg: 4m 30s | Max: 6m 53s

🟩 python: Pass: 100%/1 | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 90)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

fbusato commented Feb 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2025

🟩 cub: Pass: 100%/44 | Total: 1d 05h | Avg: 40m 00s | Max: 1h 13m | Hits: 325%/3500

🟩 thrust: Pass: 100%/43 | Total: 10h 38m | Avg: 14m 51s | Max: 58m 44s | Hits: 219%/9230

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 9m 01s | Avg: 4m 30s | Max: 6m 53s

🟩 python: Pass: 100%/1 | Total: 25m 50s | Avg: 25m 50s | Max: 25m 50s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 90)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants