Conversation
b5b6f6f to
929e6a0
Compare
929e6a0 to
a2b042e
Compare
🟨 CI finished in 1h 43m: Pass: 84%/158 | Total: 1d 11h | Avg: 13m 38s | Max: 1h 19m | Hits: 83%/206360
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 158)
| # | Runner |
|---|---|
| 111 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 8 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
80efbcf to
315fc11
Compare
🟩 CI finished in 1h 30m: Pass: 100%/158 | Total: 1d 13h | Avg: 14m 24s | Max: 1h 19m | Hits: 85%/249476
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 158)
| # | Runner |
|---|---|
| 111 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 8 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
griwes
left a comment
There was a problem hiding this comment.
Approving, but please either change the commented part, or leave some trace of the reason for it in the code.
| #if _CCCL_CUDA_COMPILER(CLANG) | ||
| # undef _CCCL_BUILTIN_ACOSF | ||
| # undef _CCCL_BUILTIN_ACOS | ||
| # undef _CCCL_BUILTIN_ACOSL | ||
| #endif // _CCCL_CUDA_COMPILER(CLANG) |
There was a problem hiding this comment.
Why this way, instead of adding && !_CCCL_CUDA_COMPILER(CLANG) to the condition around where these are defined?
There was a problem hiding this comment.
In this case its relatively simple, but we have a ton of situations where the enablement of the builtin has multiple conditions and mixing a chain of || with a chain of && ! just got ugly fast.
So we settled on splitting it into enablement and "compiler issues". That should also make it easier to spot what is a compiler issue and what is actually part of the condition
There was a problem hiding this comment.
If this is a compiler issue, we really should have a comment somewhere in there recording what it is.
* Implement trigonometric functions * Implement hyperbolic math functions * Implement inverse trigonometric functions * Implement inverse hyperbolic functions * Implement gamma functions * Implement `std::hypot` * Use variable templates in cmath tests * Avoid unused variable warnings * long double fixes * Try and fix clang-cuda
This properly implements more of the functions in
<cuda/std/cmath>I did not port more functions because those are conflictig with the ongoing work on extended floating point types