Merged
Conversation
Contributor
Author
|
/ok to test |
6779e58 to
3427e90
Compare
Contributor
🟨 CI finished in 1h 40m: Pass: 51%/93 | Total: 2d 14h | Avg: 40m 29s | Max: 1h 26m | Hits: 35%/53934
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
3427e90 to
e214f13
Compare
Contributor
🟨 CI finished in 1h 07m: Pass: 91%/93 | Total: 1d 10h | Avg: 22m 15s | Max: 1h 00m | Hits: 96%/120182
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
8ab29ce to
d307ca9
Compare
Contributor
🟨 CI finished in 1h 28m: Pass: 93%/93 | Total: 1d 01h | Avg: 16m 20s | Max: 1h 26m | Hits: 94%/125555
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
d307ca9 to
64ffdb8
Compare
Contributor
🟩 CI finished in 1h 09m: Pass: 100%/93 | Total: 17h 09m | Avg: 11m 04s | Max: 1h 00m | Hits: 94%/134475
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
miscco
reviewed
Mar 12, 2025
Contributor
🟩 CI finished in 1h 10m: Pass: 100%/93 | Total: 17h 35m | Avg: 11m 20s | Max: 1h 00m | Hits: 94%/134475
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
649f5ee to
062bfb1
Compare
Contributor
🟩 CI finished in 1h 14m: Pass: 100%/93 | Total: 20h 18m | Avg: 13m 06s | Max: 1h 09m | Hits: 93%/134475
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
miscco
approved these changes
Mar 13, 2025
elstehle
approved these changes
Mar 13, 2025
Co-authored-by: Elias Stehle <3958403+elstehle@users.noreply.github.com>
Contributor
🟩 CI finished in 1h 07m: Pass: 100%/93 | Total: 17h 29m | Avg: 11m 16s | Max: 1h 03m | Hits: 94%/134475
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 93)
| # | Runner |
|---|---|
| 66 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-arm64-cpu16 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Mar 18, 2025
* Add thrust::offset_iterator * Support custom offset types in offset_iterator * Move CUB-using test to CUDA * Remove mutation * Add example loading offset via transform_iterator and extend doc * Fx1# Please enter the commit message for your changes. Lines starting * MSVC workaround * Update after discssion with elstehle * Add select example with offset_iterator * Apply suggestions from code review Co-authored-by: Elias Stehle <3958403+elstehle@users.noreply.github.com> --------- Co-authored-by: Elias Stehle <3958403+elstehle@users.noreply.github.com>
|
Should the |
Contributor
Author
There is no such function. I assume you mean the deduction guide here: https://github.com/NVIDIA/cccl/pull/4073/files#diff-41c2e21b5544528c5931e9128123ef37f48ec73afc7a138a1b4c00395d56d752R186-R187 It severs the same purpose though. Constructing an |
|
Thanks! It is my first time seeing deduction guides in real code. |
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Apr 7, 2025
* Add thrust::offset_iterator * Support custom offset types in offset_iterator * Move CUB-using test to CUDA * Remove mutation * Add example loading offset via transform_iterator and extend doc * Fx1# Please enter the commit message for your changes. Lines starting * MSVC workaround * Update after discssion with elstehle * Add select example with offset_iterator * Apply suggestions from code review Co-authored-by: Elias Stehle <3958403+elstehle@users.noreply.github.com> --------- Co-authored-by: Elias Stehle <3958403+elstehle@users.noreply.github.com>
Artem-B
reviewed
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
offset_iteratorto Thrust that bundles a base iterator and a offset. The offset is either a value or anindirectly_readable. Dereferencing and comparing iterators will apply the offset to the base iterator. if the offset isindirectly_readable, the offset value will be loaded as required.This iterator has two use cases with different mechanics:
+=) in host code inside anoffset_iterator. Advancing the offset iterator will advance the offset and not the base iterator. This enables to use such iterators in host code as well.Related: #3767