[REVIEW] L1 distance support for iterative search CAGRA build#1831
Merged
rapids-bot[bot] merged 9 commits intoMar 7, 2026
Conversation
yan-zaretskiy
added
non-breaking
Contributor
|
/ok to test bd694e9 |
Contributor
|
/ok to test 9b3e233 |
tarang-jain
approved these changes
Feb 25, 2026
tarang-jain
left a comment
tarang-jain
left a comment
Contributor
There was a problem hiding this comment.
LGTM! It is quite amazing that we can add a metric for several different template combinations with the help of an automated python script. The descriptor and the distance op seem accurate. Also love the use of requires in place of SFINAE.
Contributor
|
/ok to test 59e8735 |
Contributor
|
/ok to test c175003 |
Contributor
|
/ok to test a77f56a |
Contributor
|
/ok to test 135c05b |
Contributor
|
/ok to test f4fa078 |
Contributor
|
/ok to test f0f8487 |
Contributor
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
rapids-bot Bot
pushed a commit
that referenced
this pull request
May 9, 2026
CUDA 13 binary size reduction from 282 MB to 257 MB (-8.86%). Benchmark: <img width="1137" height="776" alt="image" src="https://github.com/user-attachments/assets/81b4f25a-c999-423d-a2c9-3e45566904bf" /> Apply updates from CAGRA related PRs: - [x] #1800 - [ ] #1781 - [x] #1780 - [x] #1771 - [x] #1834 - [x] #1851 - [x] #1831 JIT related PRs: - [x] #1812 Authors: - Divye Gala (https://github.com/divyegala) - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Dante Gama Dessavre (https://github.com/dantegd) - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Dante Gama Dessavre (https://github.com/dantegd) URL: #1807
landrumb
pushed a commit
to landrumb/cuvs
that referenced
this pull request
Jul 8, 2026
…#1831) This PR adds L1 distance support for building the CAGRA index with the iterative search approach. This is work related to NVIDIA#1159. A follow-up PR will add L1 support for NN-Descent. Authors: - Yan Zaretskiy (https://github.com/yan-zaretskiy) - Anupam (https://github.com/aamijar) - Tarang Jain (https://github.com/tarang-jain) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Divye Gala (https://github.com/divyegala) URL: NVIDIA#1831
landrumb
pushed a commit
to landrumb/cuvs
that referenced
this pull request
Jul 8, 2026
CUDA 13 binary size reduction from 282 MB to 257 MB (-8.86%). Benchmark: <img width="1137" height="776" alt="image" src="https://github.com/user-attachments/assets/81b4f25a-c999-423d-a2c9-3e45566904bf" /> Apply updates from CAGRA related PRs: - [x] NVIDIA#1800 - [ ] NVIDIA#1781 - [x] NVIDIA#1780 - [x] NVIDIA#1771 - [x] NVIDIA#1834 - [x] NVIDIA#1851 - [x] NVIDIA#1831 JIT related PRs: - [x] NVIDIA#1812 Authors: - Divye Gala (https://github.com/divyegala) - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Dante Gama Dessavre (https://github.com/dantegd) - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#1807
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds L1 distance support for building the CAGRA index with the iterative search approach. This is work related to #1159. A follow-up PR will add L1 support for NN-Descent.