Skip to content

Add support for NO_RUNTIME_CONFIG to disable runtime config in the nvidia-container-toolkit #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elezar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for NO_RUNTIME_CONFIG to disable runtime config in the nvidia-container-toolkit #2041

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7ebf09
Add test for missing toolkit container
elezar Jan 13, 2026
11d1c5e
Add a check for NO_RUNTIME_CONFIG=true to disable runtime config in t…
elezar Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test for missing toolkit container 
Signed-off-by: Evan Lezar <elezar@nvidia.com>
  • Loading branch information
@elezar
elezar committed Jan 20, 2026
commit a7ebf09cbe18787ae7c05e4cce03a7d8dceda1d0
20 changes: 14 additions & 6 deletions controllers/transforms_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package controllers

import (
"errors"
"path/filepath"
"testing"

Expand Down Expand Up @@ -777,11 +778,12 @@ func TestApplyCommonDaemonsetMetadata(t *testing.T) {

func TestTransformToolkit(t *testing.T) {
testCases := []struct {
description string
ds Daemonset // Input DaemonSet
cpSpec *gpuv1.ClusterPolicySpec // Input configuration
runtime gpuv1.Runtime
expectedDs Daemonset // Expected output DaemonSet
description string
ds Daemonset // Input DaemonSet
cpSpec *gpuv1.ClusterPolicySpec // Input configuration
runtime gpuv1.Runtime
expectedError error
expectedDs Daemonset // Expected output DaemonSet
}{
{
description: "transform nvidia-container-toolkit-ctr container",
Expand Down Expand Up @@ -1002,6 +1004,12 @@ func TestTransformToolkit(t *testing.T) {
WithHostPathVolume("crio-config", "/etc/crio", ptr.To(corev1.HostPathDirectoryOrCreate)).
WithHostPathVolume("crio-drop-in-config", "/etc/crio/crio.conf.d", ptr.To(corev1.HostPathDirectoryOrCreate)),
},
{
description: "no nvidia-container-toolkit-ctr container",
ds: NewDaemonset(),
expectedError: errors.New(`failed to find toolkit container "nvidia-container-toolkit-ctr"`),
expectedDs: NewDaemonset(),
},
}

for _, tc := range testCases {
Expand All @@ -1012,7 +1020,7 @@ func TestTransformToolkit(t *testing.T) {
}

err := TransformToolkit(tc.ds.DaemonSet, tc.cpSpec, controller)
require.NoError(t, err)
require.EqualValues(t, tc.expectedError, err)
require.EqualValues(t, tc.expectedDs, tc.ds)
})
}
Expand Down