Make NICo storage class handling configurable#2034
Open
praveendhawan wants to merge 1 commit into
Open
Conversation
praveendhawan
force-pushed
the
feature/add-optional-storage-class
branch
from
408a791 to
307188b
Compare
Add postgresql.storageClass to the nico-prereqs chart so operators can choose the StorageClass used by the Zalando-managed NICo Postgres cluster. The default remains local-path-persistent to preserve existing behavior. Add NICO_MANAGE_DEFAULT_STORAGE_CLASS to setup.sh. By default setup still annotates local-path as the default StorageClass, but operators can set NICO_MANAGE_DEFAULT_STORAGE_CLASS=false to leave an existing cluster default unchanged. Add NICO_STORAGE_CLASS to setup.sh for Vault data and audit PVCs. The default remains local-path-persistent, while operators can set it to an existing production StorageClass such as rook-ceph-block. Signed-off-by: Praveen Dhawan <praveen.dhawan@e2enetworks.com>
praveendhawan
force-pushed
the
feature/add-optional-storage-class
branch
from
307188b to
e2ec292
Compare
Collaborator
|
/ok to test e2ec292 |
ajf
approved these changes
Jun 1, 2026
Collaborator
|
@praveendhawan I see you use yadm for your dot files as well! I'll have to check them out. |
lachen-nv
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add postgresql.storageClass to the nico-prereqs chart so operators can choose the StorageClass used by the Zalando-managed NICo Postgres cluster.
The default remains local-path-persistent to preserve existing behavior.
Add NICO_MANAGE_DEFAULT_STORAGE_CLASS to setup.sh. By default setup still annotates local-path as the default StorageClass, but operators can set NICO_MANAGE_DEFAULT_STORAGE_CLASS=false to leave an existing cluster default unchanged.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes
Validated chart rendering with an overridden storage class:
Confirmed the rendered Postgres CR contains:
Existing behavior is preserved unless operators explicitly opt out by setting:
This is useful for clusters where a production StorageClass is already managed outside NICo setup.