fix(rest-api): Populate RoutingProfileType directly from the controller value#2150
Conversation
… sent from the controller
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-06-03 01:54:02 UTC | Commit: 65add65 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
thossain-nv
left a comment
There was a problem hiding this comment.
Thanks @bcavnvidia. We could also pass it as an argument to tenant.ToUpdateRequestProto()
Description
we don't sync tenant routing profile details from core to rest. Core expects full updates for objects (i.e., it expects all fields) and empty fields signal a "clear". If a tenant change in the REST API triggers an update from the inventory processes, rest-api is sending tenant updates and not setting the profile field because it's not aware of it. From core's pov, it's an attempt to change/clear the profile type, and it will be rejected if the tenant has VPCs.
This PR updates the inventory process to echo back the tenant routing profile until this becomes a new tenant model field in the REST API and is fully synced.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes