Skip to content

fix(rest-api): Populate RoutingProfileType directly from the controller value#2150

Merged
bcavnvidia merged 1 commit into
NVIDIA:mainfrom
bcavnvidia:rest-tenant
Jun 3, 2026
Merged

fix(rest-api): Populate RoutingProfileType directly from the controller value#2150
bcavnvidia merged 1 commit into
NVIDIA:mainfrom
bcavnvidia:rest-tenant

Conversation

@bcavnvidia
Copy link
Copy Markdown
Contributor

Description

we don't sync tenant routing profile details from core to rest. Core expects full updates for objects (i.e., it expects all fields) and empty fields signal a "clear". If a tenant change in the REST API triggers an update from the inventory processes, rest-api is sending tenant updates and not setting the profile field because it's not aware of it. From core's pov, it's an attempt to change/clear the profile type, and it will be rejected if the tenant has VPCs.

This PR updates the inventory process to echo back the tenant routing profile until this becomes a new tenant model field in the REST API and is fully synced.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@bcavnvidia bcavnvidia requested a review from a team as a code owner June 3, 2026 01:51
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 61ccc14e-3343-48fa-bd9e-72d0dbac24e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-06-03 01:54:02 UTC | Commit: 65add65

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
nico-flow 66 4 34 18 2 8
nico-nsm 82 2 28 43 9 0
nico-psm 67 4 35 18 2 8
nico-rest-api 100 6 53 30 3 8
nico-rest-cert-manager 65 4 34 18 1 8
nico-rest-db 66 4 34 18 2 8
nico-rest-site-agent 65 4 34 18 1 8
nico-rest-site-manager 65 4 34 18 1 8
nico-rest-workflow 67 4 35 18 2 8
TOTAL 643 36 321 199 23 64

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Copy link
Copy Markdown
Contributor

@thossain-nv thossain-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcavnvidia. We could also pass it as an argument to tenant.ToUpdateRequestProto()

@bcavnvidia bcavnvidia merged commit 0ac2782 into NVIDIA:main Jun 3, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants