ci(rest): post-migration cleanup #2153
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-06-03 03:58:47 UTC | Commit: 8eef038 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
…oid Docker Hub 429
lachen-nv
changed the title
thossain-nv
left a comment
thossain-nv
left a comment
There was a problem hiding this comment.
Looks good, thank you @lachen-nv
|
🌿 Preview your docs: https://nvidia-preview-pull-request-2153.docs.buildwithfern.com/infra-controller |
# Conflicts: # rest-api/.github/ISSUE_TEMPLATE/bug_report_form.yml # rest-api/.github/ISSUE_TEMPLATE/config.yml # rest-api/.github/ISSUE_TEMPLATE/documentation_request_correction.yml # rest-api/.github/ISSUE_TEMPLATE/documentation_request_new.yml # rest-api/.github/ISSUE_TEMPLATE/feature_request_form.yml
nv-dmendoza
left a comment
nv-dmendoza
left a comment
There was a problem hiding this comment.
Also LGTM, thanks @lachen-nv !
Follow-up to the REST CI migration, addressing @thossain-nv's CI/CD suggestions. ## Changes (3 commits) 1. **Move REST CI build/test/helm jobs to IPP-managed runners** — REST jobs mostly ran on `ubuntu-latest` (GitHub-hosted); core uses the `linux-amd64-cpu4`. Aligned the REST build/test/lint/helm jobs onto `linux-amd64-cpu4` for consistency + speed. The two trivial jobs (`changes` gate + `rest-ci-pass` aggregator) intentionally stay on `ubuntu-latest`. 2. **Remove dead `rest-api/.github/`** — leftover from the subtree merge; GitHub only executes workflows from the repo-root `.github/`, so these never ran. CODEOWNERS entries there are already covered by the root `.github/CODEOWNERS`, so nothing to migrate. 3. **Rename workflow `Carbide CI` → `NICo Core CI`** (+ `notify-build-status` default label + a stale comment). Cosmetic — branch protection keys off the job name `core-ci-pass`, not the workflow display name, and no `workflow_run` trigger depends on the old name, so nothing breaks. ## Notes - `promotion.yaml` / `release.yaml` (`Carbide *`) left as-is to keep scope tight; can rebrand later.
4 participants
Follow-up to the REST CI migration, addressing @thossain-nv's CI/CD suggestions.
Changes (3 commits)
ubuntu-latest(GitHub-hosted); core uses thelinux-amd64-cpu4. Aligned the REST build/test/lint/helm jobs ontolinux-amd64-cpu4for consistency + speed. The two trivial jobs (changesgate +rest-ci-passaggregator) intentionally stay onubuntu-latest.rest-api/.github/— leftover from the subtree merge; GitHub only executes workflows from the repo-root.github/, so these never ran. CODEOWNERS entries there are already covered by the root.github/CODEOWNERS, so nothing to migrate.Carbide CI→NICo Core CI(+notify-build-statusdefault label + a stale comment). Cosmetic — branch protection keys off the job namecore-ci-pass, not the workflow display name, and noworkflow_runtrigger depends on the old name, so nothing breaks.Notes
promotion.yaml/release.yaml(Carbide *) left as-is to keep scope tight; can rebrand later.