fix: nvlink partitioning metrics#247
Closed
tmcroberts97 wants to merge 1 commit into
Closed
Conversation
- Always record metrics, even if the partition monitor encounters an error. - populate the operation name correctly in metrics' applied changes tracker. Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
Matthias247
reviewed
Feb 11, 2026
| otel.status_message = tracing::field::Empty, | ||
| metrics = tracing::field::Empty, | ||
| ); | ||
| let _enter = check_nvl_partition_span.enter(); |
Contributor
There was a problem hiding this comment.
i think that doesn't work with async/await. You need self.run_single_iteration_inner(&mut metrics).instrument(check_nvl_partition_span).await
Contributor
Author
|
Closing in favour of #275 because the fork is stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes some issues with nvlink partitioning metrics:
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes