fix: Issue all queued nmx-m operations even if the monitor encounters an error#249
Closed
tmcroberts97 wants to merge 1 commit into
Closed
fix: Issue all queued nmx-m operations even if the monitor encounters an error#249tmcroberts97 wants to merge 1 commit into
tmcroberts97 wants to merge 1 commit into
Conversation
Do not exit early from execute_nmx_m_operations() if we cannot issue an operation to NMX-M. Instead add only successfully enqueued operations to pending list and ignore any that errored out. Exiting execute_nmx_m_operations() early with an error was resulting in skipped db updates even for those operations that were successfully enqueued and completed by NMX-M. Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
tmcroberts97
force-pushed
the
fix/nvl-monitor-early-exit
branch
from
edc3e6a to
34a943c
Compare
Contributor
Author
|
Closing because of stale fork, opening #273 instead |
kfelternv
added a commit
to kfelternv/infra-controller
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not exit early from execute_nmx_m_operations() if we cannot issue an operation to NMX-M. Instead add only successfully enqueued operations to pending list and ignore any that errored out. Exiting execute_nmx_m_operations() early with an error was resulting in skipped db updates even for those operations that were successfully enqueued and completed by NMX-M.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes