Jitify2 misc fixes#128
Merged
Merged
Conversation
12 tasks
maddyscientist
approved these changes
Feb 8, 2024
maddyscientist
left a comment
maddyscientist
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Given my tardiness in reviewing this, @benbarsdell do you want to update the years to 2024 on this before we merge?
- This avoids "incompatible redefinition" errors.
- Adds launch_raw() methods to replace overloads that take array of arg pointers, which were dangerously ambiguous with the variadic overload. - Adds explicit no-argument overload of launch() to avoid forming zero-sized array.
- This matches the definitions in libcucxx.
benbarsdell
force-pushed
the
jitify2-misc-fixes2
branch
from
410c320 to
0d42248
Compare
Contributor
Author
|
Thanks, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some minor fixes/improvements and fixes tests for CUDA 12.3 (full details in commit messages).
Edit: Added a few more things.