Jitify2 options handling overhaul#129
Merged
Merged
Conversation
benbarsdell
commented
Oct 20, 2023
benbarsdell
commented
Contributor
- Refactors all options handling to use a single parser implementation and new Options and OptionsVec classes.
- This makes the code significantly cleaner and more robust.
- Maintains backwards compatibility with string vectors at API boundaries via implicit conversions.
| #endif | ||
|
|
||
| #include <algorithm> | ||
| #include <cassert> |
Collaborator
There was a problem hiding this comment.
Why the repeated includes in the different JITIF_SERIALIZATION_ONLY paths? Can these not just be factored out and moved above line 46?
maddyscientist
approved these changes
May 21, 2024
maddyscientist
left a comment
maddyscientist
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (beyond a trivial comment().
- Refactors all options handling to use a single parser implementation and new Options and OptionsVec classes. - This makes the code significantly cleaner and more robust. - Maintains backwards compatibility with string vectors at API boundaries via implicit conversions.
benbarsdell
force-pushed
the
jitify2-options-handling-overhaul-new
branch
from
942fb9c to
7bc924e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.