Address jitify2 warnings under Visual Studio 2022#132
Merged
Conversation
2ad86c9 to
865ed7e
Compare
maddyscientist
approved these changes
Feb 8, 2024
maddyscientist
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution (and sorry for the slow review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3 warnings addressed are shown below.
Haven't managed to resolve all issues on our CI yet, so may have further changes.
CUDA 11.0 x Visual Studio 2019 is unhappy with something related to the implementation of
SafeFunction, but its a nasty template err related tostd::function.(Resolved)
manylinux2014 is unhappy with the use of
F_OFD_SETLKW.In both of these cases, I'm assuming compiler/stdlib age is the issue. I'm told we still require support for manylinux2014 as several HPC systems are still running centos7, however we may be able to address that issue by switching to the less safe
F_OFDflag under centos7.