elezar comments for NRI plugin server#1581
Closed
elezar wants to merge 5 commits intoNVIDIA:nri-plugin-serverfrom
Closed
elezar comments for NRI plugin server#1581elezar wants to merge 5 commits intoNVIDIA:nri-plugin-serverfrom
elezar wants to merge 5 commits intoNVIDIA:nri-plugin-serverfrom
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change adds an interface (and a basic type) for configuring a target runtime from the nvidia-ctk-installer. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
tariq1890
force-pushed
the
nri-plugin-server
branch
from
4a28997 to
a348c23
Compare
tariq1890
reviewed
Jan 15, 2026
| Sources: cli.EnvVars("TOOLKIT_PID_FILE", "PID_FILE"), | ||
| }, | ||
| &cli.BoolFlag{ | ||
| Name: "enable-nri-in-runtime", |
Contributor
There was a problem hiding this comment.
I prefer --enable-nri-plugin as it's more explicit in what it's trying to do
tariq1890
force-pushed
the
nri-plugin-server
branch
4 times, most recently
from
9078cfe to
f15030c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a proposal for a cleanup of #1498
It includes some of the intial commits from #1521 and builds on that to ensure that the runtime is not configured if NRI is enabled. Note that the config options are moved to top-level flags since we don't propagate the NRI config to the runtime.