Add configurable CorrDiff regression loss selection - #1877
Open
younes-abid wants to merge 3 commits into
Open
Conversation
Signed-off-by: younes.abid <mr.younes.abid@gmail.com>
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @CharlelieLrt — 5 file(s)
No CODEOWNER
Comment |
Contributor
Greptile SummaryAdds configurable CorrDiff regression-loss selection while preserving
Important Files Changed
Reviews (1): Last reviewed commit: "Add configurable CorrDiff regression los..." | Re-trigger Greptile |
Signed-off-by: younes.abid <mr.younes.abid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
This PR adds configurable regression loss selection for the CorrDiff training
path when using
regressionandlt_aware_regressionmodel names.What changed
lossfield in CorrDiff regression model configs.examples/weather/corrdiff/train.py, withRegressionLossas default to preserve existing behavior.RegressionHuberLossRegressionCharbonnierLossRegressionEdgeAwareLossRegressionShiftTolerantLossRegressionHybridStructuralLossWhy
This improves flexibility for CorrDiff regression training by allowing loss
function selection from config without changing code, while preserving backward
compatibility through the existing default loss.
Checklist
Dependencies
No new runtime dependencies were added.
Review Process
I understand this PR will be reviewed by the PhysicsNeMo team and that
AI-generated comments are advisory.