Mesh: support integer and boolean fields in point_data_to_cell_data - #1880
Draft
peterdsharpe wants to merge 1 commit into
Draft
Mesh: support integer and boolean fields in point_data_to_cell_data#1880peterdsharpe wants to merge 1 commit into
peterdsharpe wants to merge 1 commit into
Conversation
point_data_to_cell_data called torch.mean directly on the gathered vertex values, which raises for integer and boolean point fields. Those dtypes are common after importing VTK IDs and markers. Integer and boolean values are now promoted to float64 before averaging, matching cell_data_to_point_data; floating-point and complex fields keep their dtype.
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @peterdsharpe — 2 file(s)
No CODEOWNER
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Mesh.point_data_to_cell_data()callstorch.meanon each point field, which raises for integer and boolean tensors. These dtypes commonly arrive from VTK arrays such as node IDs, region tags, and wall markers, so ordinary imported meshes can fail during point-to-cell conversion.This PR:
float64, and then computes the mean.cell_data_to_point_data()and facet aggregation.Verification
pytest test/mesh: 2350 passed, 701 skipped.ruff check,ruff format --check, and the pre-commit checks pass.Checklist
Dependencies
None.
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score. This score reflects the AI's assessment of merge readiness and is not a qualitative judgment of the work or an indication that the PR will be accepted or rejected.
AI-generated feedback should be reviewed critically for usefulness. You are not required to respond to every AI comment, but they are intended to help both authors and reviewers. Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.