Skip to content

Miscellaneous fixes - #1884

Merged
peterdsharpe merged 5 commits into
NVIDIA:mainfrom
peterdsharpe:psharpe/misc-fixes
Aug 4, 2026
Merged

Miscellaneous fixes#1884
peterdsharpe merged 5 commits into
NVIDIA:mainfrom
peterdsharpe:psharpe/misc-fixes

Conversation

@peterdsharpe

Copy link
Copy Markdown
Collaborator

Summary

  • add range and overflow checks around Warp-backed neighbor and mesh operations
  • correct archive member filtering and improve remote artifact fetching
  • tighten example dataset and experiment-logging behavior
  • document reproducible checksums for externally hosted example data

Details

This collects several independent correctness and robustness fixes:

  • prefix sums are accumulated in int64 and checked before conversion to the int32 offsets required by Warp kernels
  • mesh face indices are validated before native SDF and raycast execution
  • archive extraction accepts only contained regular files and directories
  • the package filesystem supports HTTPS, response checking, atomic cache writes, and optional SHA-256 verification while retaining the existing HTTP behavior with a warning
  • the diffusion example disables unnecessary object-array loading for its numeric dataset
  • experiment configuration summaries redact credential-like fields, and W&B initialization now preserves configured values correctly

Established checkpoint extensibility and existing dataset/cache serialization formats remain unchanged.

Validation

  • focused changed-behavior tests: 35 passed, 3 skipped
  • radius-search and Poisson sampling tests: 187 passed, 4 skipped
  • checkpoint, datapipe, and HEALPix compatibility tests: 75 passed, 32 skipped
  • direct CUDA/Warp FigConv smoke test passed
  • Ruff, Python/YAML syntax checks, and git diff --check passed

@copy-pr-bot

copy-pr-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test a3913f4

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS review map

Current for commit 4cde61f55c35. An approval covers every file listed for that owner; one owner is sufficient for shared files.

@CharlelieLrt — 2 file(s)
  • physicsnemo/core/filesystem.py
  • physicsnemo/core/module.py
@coreyjadams — 3 file(s)
  • examples/cfd/external_aerodynamics/domino/README.md
  • physicsnemo/models/figconvnet/warp_neighbor_search.py
  • test/core/test_filesystem.py
@ktangsali — 2 file(s)
  • physicsnemo/core/filesystem.py
  • physicsnemo/core/module.py
@loliverhennigh — 4 file(s)
  • physicsnemo/nn/functional/geometry/mesh_poisson_disk_sample/_warp_impl/op.py
  • physicsnemo/nn/functional/geometry/sdf.py
  • physicsnemo/nn/functional/neighbors/radius_search/_warp_impl.py
  • physicsnemo/nn/functional/rendering/mesh_raycast/_warp_impl.py
@mnabian — 7 file(s)
  • examples/cfd/lagrangian_mgn/README.md
  • examples/cfd/lagrangian_mgn/conf/config.yaml
  • examples/cfd/lagrangian_mgn/conf/config_2d.yaml
  • examples/cfd/lagrangian_mgn/conf/config_3d.yaml
  • examples/cfd/lagrangian_mgn/inference.py
  • examples/cfd/lagrangian_mgn/loggers.py
  • examples/cfd/lagrangian_mgn/train.py
@peterdsharpe — 2 file(s) (covered by co-owner)
  • physicsnemo/nn/functional/geometry/sdf.py
  • physicsnemo/nn/functional/neighbors/radius_search/_warp_impl.py

No CODEOWNER

  • examples/cfd/flow_reconstruction_diffusion/README.md
  • examples/cfd/flow_reconstruction_diffusion/generate_dfsr.py
  • test/examples/test_lagrangian_mgn_loggers.py
  • test/models/test_from_checkpoint.py
  • test/nn/functional/geometry/test_sdf.py
  • test/nn/functional/rendering/test_mesh_raycast.py

Comment /codeowners-info to refresh.

@peterdsharpe
peterdsharpe marked this pull request as ready for review July 28, 2026 20:47
Comment thread physicsnemo/core/filesystem.py Outdated
Comment thread physicsnemo/nn/functional/geometry/sdf.py
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR strengthens validation and integrity handling across remote artifacts, checkpoint extraction, Warp geometry operations, and example logging behavior.

  • Adds HTTPS, response checking, atomic HTTP cache writes, and optional SHA-256 verification.
  • Restricts checkpoint archive extraction to contained regular files and directories.
  • Detects neighbor-count overflow before converting offsets required by Warp kernels.
  • Validates mesh connectivity before SDF and raycast execution.
  • Redacts credential-like configuration fields and corrects W&B initialization assignments.
  • Tightens example dataset loading and documents externally hosted dataset checksums.

Important Files Changed

Filename Overview
physicsnemo/core/filesystem.py Adds secure HTTP(S) retrieval and checksum-aware caching, but checksum-failure cleanup remains racy for shared-cache callers.
physicsnemo/core/module.py Correctly restricts archive extraction to contained regular files and directories.
physicsnemo/nn/functional/neighbors/radius_search/_warp_impl.py Accumulates neighbor offsets in int64 and checks totals before the required int32 Warp conversion.
physicsnemo/models/figconvnet/warp_neighbor_search.py Prevents prefix-sum overflow while preserving the existing int32 kernel interface.
physicsnemo/nn/functional/geometry/mesh_poisson_disk_sample/_warp_impl/op.py Adds checked int64 CSR prefix accumulation before allocating and launching int32-offset kernels.
physicsnemo/nn/functional/geometry/sdf.py Rejects invalid mesh connectivity before native execution, but scalar bounds extraction synchronizes CUDA execution.
physicsnemo/nn/functional/rendering/mesh_raycast/_warp_impl.py Adds vertex-index bounds validation for Warp raycasting, with the same eager CUDA synchronization cost as SDF validation.
examples/cfd/lagrangian_mgn/loggers.py Redacts credential-like configuration values and fixes W&B key and run-ID assignment precedence.
examples/cfd/flow_reconstruction_diffusion/generate_dfsr.py Disables unnecessary pickle-backed object-array loading for the numeric reconstruction dataset.

Reviews (1): Last reviewed commit: "Miscellaneous fixes" | Re-trigger Greptile

@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test 4cde61f

@mnabian mnabian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lagrangian MGN changes LGTM, thanks!

@ktangsali ktangsali left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to module.py and filesystem.py look good.

Comment thread physicsnemo/core/module.py Outdated

@CharlelieLrt CharlelieLrt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loliverhennigh loliverhennigh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comment on my side

@coreyjadams

Copy link
Copy Markdown
Collaborator

/codeowners-info

@coreyjadams coreyjadams left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive reviewed my portion of the files here, thanks Peter!

@peterdsharpe

Copy link
Copy Markdown
Collaborator Author

/ok to test 98bf3f7

@peterdsharpe
peterdsharpe enabled auto-merge August 4, 2026 13:58
@peterdsharpe
peterdsharpe added this pull request to the merge queue Aug 4, 2026
Merged via the queue into NVIDIA:main with commit fc225b2 Aug 4, 2026
15 checks passed
@peterdsharpe
peterdsharpe deleted the psharpe/misc-fixes branch August 4, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants