Open
Conversation
jesusdoesnotloveyou
commented
Apr 1, 2026
jesusdoesnotloveyou
commented
- Curvature feature from Igehy's paper (work in progress)
- Light color clamping problem fixed (i hope)
- Light sampling changes: emission/solid angle stuff
- Minor changes and cleanup
…n added (for radiance estimate)
Photon Gathering disabled in evaluation shader (causes hyper intensity problems).
…s and photons, respectively). The mathematical calculations for tracing photon differentials require adjustment and verification. A placeholder for surface curvature (a calculation based on the normals of a triangular primitive must be implemented).
0.906f set as a new one according to most ReSTIR papers.
1. Photon footprints (AABB) collecting has been rewritten to eliminate to much if-statements. 2. Clamp on caustic photon AABB has been added. 3. Surface curvature feature (work in progress). Check AAPS Ray-Traced caustic for more details. 4. Light sampling changes: solid angle calculation for emission from point and spot lights (still not sure if it works correctly).
…liar function 'evaluateDifferentialWeight' in StructAndHelpers.slang. 2. FootprintArea division replaced to avoid light color clamping (or smth).
…s of the triangle primitive for normal derivative calculation
2. note about total internal reflection (OMITTED for now!)
…for now, so it does not really affect the denoising process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.