Skip to content

Cron job to clear search#269

Merged
the-codetrane merged 3 commits intomainfrom
cron-job-to-clear-search
Aug 8, 2023
Merged

Cron job to clear search#269
the-codetrane merged 3 commits intomainfrom
cron-job-to-clear-search

Conversation

@the-codetrane
Copy link
Contributor

Problem

We persist search objects and need a manner by which to vacate old search data

Solution

  • write a rake task to vacate searches that are a week old
  • use whenever to create a scheduled cron job

PR Type

  • Feature
  • Tests
  • Janitorial (refactoring, dependency updates, etc.)

@the-codetrane the-codetrane requested a review from mnyrop June 22, 2023 12:59
@the-codetrane
Copy link
Contributor Author

This PR is to create the whenever schedule and rake task. We'll need to find a way to invoke whenever to write to the cron tab on the box on deploy:
image

@mnyrop
Copy link
Member

mnyrop commented Jun 22, 2023

@the-codetrane Looks good to me! Since this'll interact with the mysql DB on prod (and we don't have testing for it), my inclination would be to ship this in a standalone tag and make sure it works properly isolated from the other changes. With that in mind, is OK if we keep this PR in the hopper for a later deploy? Also open to opinions from @dxu1789

@the-codetrane the-codetrane added dependencies Pull requests that update a dependency file devops labels Jun 22, 2023
@the-codetrane the-codetrane force-pushed the cron-job-to-clear-search branch from dd6b6a0 to 5843920 Compare August 8, 2023 16:11
@the-codetrane the-codetrane merged commit 85b06f6 into main Aug 8, 2023
@the-codetrane the-codetrane deleted the cron-job-to-clear-search branch August 8, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file devops

Development

Successfully merging this pull request may close these issues.

2 participants