Skip to content

Deprecate figs II#271

Merged
mnyrop merged 11 commits intomainfrom
deprecate-figs
Jul 14, 2023
Merged

Deprecate figs II#271
mnyrop merged 11 commits intomainfrom
deprecate-figs

Conversation

@the-codetrane
Copy link
Contributor

@the-codetrane the-codetrane commented Jul 5, 2023

Problem

figs is a proprietary config gem that has been abandoned and is blocking the Ruby/Rails upgrade

Solution

  • use config gem instead
  • use dot-env gem to manage ENV variables outside of Settings class

PR Type

  • Feature
  • Tests
  • Janitorial (refactoring, dependency updates, etc.)

@the-codetrane the-codetrane requested a review from mnyrop July 5, 2023 14:33
@mnyrop
Copy link
Member

mnyrop commented Jul 13, 2023

@the-codetrane some follow ups:

It would be great if you could write some notes on how you got this working on staging and where/what you changed in terms of vars/files within the EC2 so we can make sure its reproducible later.

@the-codetrane
Copy link
Contributor Author

the-codetrane commented Jul 14, 2023

Yeah, these should be read in from Settings like all the other var's; updated.

  • What's the new workflow? Do config/vars.yml and config/vars.yml.example get deleted and we copy the secret vars file (from box) to /config/settings/production.yml on prod instead?

Yes, we'll need to flatten vars.yml for production into a production.yml file that gets put into configs/settings. It'll also provide a nice separation of concerns to make sure only env-specific configs end up in prod.

So the main changes will be:

  • in Box, remove vars.yml and replace it with production.yml with the production-specific key/value pairs
  • cp production.yml config/settings

This should get the correctly-formatted file into the place where config will pick it up

@mnyrop
Copy link
Member

mnyrop commented Jul 14, 2023

@the-codetrane sounds good! Thanks for the write up. Just send me that production.yml file over Slack when you get the chance and I'll add it to Box.

@mnyrop mnyrop merged commit b33ef28 into main Jul 14, 2023
@mnyrop mnyrop deleted the deprecate-figs branch July 14, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants