Conversation
JackMeadDev
left a comment
There was a problem hiding this comment.
Nice work, you've got a really clear simple Dockerfile, and I was easily able to run your app both in dev & prod containers 😄 I've left a couple of optional thoughts below, but very happy for you to merge when you're ready!
| .venv | ||
| Dockerfile | ||
| .vscode | ||
| README.md |
There was a problem hiding this comment.
An extra folder I might consider adding:
| README.md | |
| README.md | |
| **/__pycache__ |
(Note the **/ at the start is required to ignore subfolders, unlike .gitignore which ignores both folders in the root and sub-folders automatically)
JackMeadDev
left a comment
There was a problem hiding this comment.
(Reviewing M6 diagrams here now)
As per our recent conversation, the diagrams look great. If we were building them for work we might well make them a bit prettier, but in terms of really focusing on the core details and ideas, I think these are really clear and effective. Nice work - go ahead and merge when you're ready!
Co-authored-by: JackMead <jack.mead@corndel.com>
Co-authored-by: JackMead <jack.mead@corndel.com>
Please make sure you are raising this PR against your own repository and not the original. If it says https://github.com/CorndelWithSoftwire in the search bar right now, you are in the wrong place!
Please also don't forget to submit the PR's url to Aptem afterwards (by clicking on the corresponding exercise component, pasting the url in the textbox that appears and then pressing the finish button).