Skip to content

Mod5#2

Merged
Nasirhus merged 5 commits into
masterfrom
Mod5
Jul 19, 2024
Merged

Mod5#2
Nasirhus merged 5 commits into
masterfrom
Mod5

Conversation

@Nasirhus
Copy link
Copy Markdown
Owner

@Nasirhus Nasirhus commented Apr 5, 2024

Please make sure you are raising this PR against your own repository and not the original. If it says https://github.com/CorndelWithSoftwire in the search bar right now, you are in the wrong place!

Please also don't forget to submit the PR's url to Aptem afterwards (by clicking on the corresponding exercise component, pasting the url in the textbox that appears and then pressing the finish button).

Copy link
Copy Markdown
Collaborator

@JackMeadDev JackMeadDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you've got a really clear simple Dockerfile, and I was easily able to run your app both in dev & prod containers 😄 I've left a couple of optional thoughts below, but very happy for you to merge when you're ready!

Comment thread README.md Outdated
Comment thread Dockerfile Outdated
Comment thread .dockerignore
.venv
Dockerfile
.vscode
README.md
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An extra folder I might consider adding:

Suggested change
README.md
README.md
**/__pycache__

(Note the **/ at the start is required to ignore subfolders, unlike .gitignore which ignores both folders in the root and sub-folders automatically)

Copy link
Copy Markdown
Collaborator

@JackMeadDev JackMeadDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Reviewing M6 diagrams here now)

As per our recent conversation, the diagrams look great. If we were building them for work we might well make them a bit prettier, but in terms of really focusing on the core details and ideas, I think these are really clear and effective. Nice work - go ahead and merge when you're ready!

Nasirhus and others added 2 commits July 19, 2024 10:21
Co-authored-by: JackMead <jack.mead@corndel.com>
Co-authored-by: JackMead <jack.mead@corndel.com>
@Nasirhus Nasirhus merged commit 951353d into master Jul 19, 2024
@Nasirhus Nasirhus deleted the Mod5 branch July 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants