Correct SizingMethod variable initialization by rraustad · Pull Request #11461 · NatLabRockies/EnergyPlus

rraustad · 2026-03-12T15:19:26Z

Pull request overview

Fixes Unintialized SizingMethod variable on Linux 24.04 for "UnitarySystemModel_MultiSpeedDXCoolCoil_Only_NoFan" #11460

Description of the purpose of this PR

The UnitarySystem model uses scalable sizing inputs that need to be correctly initialized according to user inputs.

Pull Request Author

Reviewer

github-actions · 2026-03-12T15:43:48Z

⚠️ Regressions detected on ubuntu-24.04 for commit `3552d2c`

Regression Summary

Audit: 5
EIO: 12
Table Big Diffs: 12
ERR: 4
ESO Big Diffs: 6
Table String Diffs: 7
MTR Big Diffs: 4
MTR Small Diffs: 1

github-actions · 2026-03-12T16:06:23Z

⚠️ Regressions detected on macos-14 for commit `3552d2c`

Regression Summary

Audit: 5
EIO: 12
Table Big Diffs: 12
ERR: 4
ESO Big Diffs: 6
Table String Diffs: 7
MTR Big Diffs: 4
MTR Small Diffs: 1

github-actions · 2026-03-12T17:02:40Z

⚠️ Regressions detected on macos-14 for commit `c3581a8`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

github-actions · 2026-03-12T17:03:01Z

⚠️ Regressions detected on ubuntu-24.04 for commit `c3581a8`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

rraustad · 2026-03-13T00:15:36Z

src/EnergyPlus/UnitarySystem.cc

+            if (this->m_HeatPump) {
+                EqSizing.SizingMethod(HVAC::HeatingAirflowSizing) = HeatingSAFlowMethod;
+            }
+        }


I really can't believe that this type of code failure (initializing a necessary sizing array variable) lasted this long. It could be that some clean up or refador caused this but in the end this seems to fix it, along with the 2 logic changes below.

rraustad · 2026-03-13T00:16:20Z

tst/EnergyPlus/unit/UnitarySystem.unit.cc

    // cooling coil air inlet node temp is greater than cooling coil air outlet node temp
    EXPECT_GT(state->dataLoopNodes->Node(thisSys->AirInNode).Temp, state->dataLoopNodes->Node(thisSys->AirOutNode).Temp);
-    EXPECT_NEAR(thisSys->m_CoolingCycRatio, 0.36056, 0.001);
+    EXPECT_NEAR(thisSys->m_CoolingCycRatio, 0.37971, 0.001);


I assume that a change like this is caused by the code taking a different path now.

rraustad · 2026-03-13T00:31:10Z

tst/EnergyPlus/unit/HVACHXAssistedCoolingCoil.unit.cc

    DataZoneEquipment::GetZoneEquipmentData(*state); // read zone equipment configuration and list objects

    state->dataSize->ZoneEqSizing.allocate(1);
+    state->dataSize->ZoneEqSizing(1).SizingMethod.allocate(25);


A unit test that does not use ZoneUnitarySysTest fixture (where these are already allocated) will need to allocate these, the 2nd one because of this code change. This unit test uses EnergyPlusFixture.

github-actions · 2026-03-13T00:35:03Z

⚠️ Regressions detected on macos-14 for commit `7076cfa`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

github-actions · 2026-03-13T00:40:28Z

⚠️ Regressions detected on ubuntu-24.04 for commit `7076cfa`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

rraustad · 2026-03-13T00:57:06Z

I do not understand these CI diffs. I do expect potential diffs but I also expect them to match my local results. If I run PackagedTerminalAirConditionerVSAS in this branch and develop I get these results using weather file LOCATION,Miami Intl Ap,FL,USA,TMY3,722020.

develop:

Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, ZONE2PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.21487          
Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, ZONE3PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.42782

this branch:

Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, ZONE2PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.21487          
Component Sizing Information, ZoneHVAC:PackagedTerminalAirConditioner, ZONE3PTAC, Design Size Heating Supply Air Flow Rate [m3/s], 0.42782

The CI shows:

- Component Sizing Information, ZoneHVAC:PackagedTerminalHeatPump, ZONE2PTHP, Design Size Heating Supply Air Flow Rate [m3/s], 0.21956          
+ Component Sizing Information, ZoneHVAC:PackagedTerminalHeatPump, ZONE2PTHP, Design Size Heating Supply Air Flow Rate [m3/s], 0.29283          

- Component Sizing Information, ZoneHVAC:PackagedTerminalHeatPump, ZONE3PTHP, Design Size Heating Supply Air Flow Rate [m3/s], 0.34232          
+ Component Sizing Information, ZoneHVAC:PackagedTerminalHeatPump, ZONE3PTHP, Design Size Heating Supply Air Flow Rate [m3/s], 0.45655

github-actions · 2026-03-13T01:54:30Z

⚠️ Regressions detected on macos-14 for commit `9ac61ed`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

github-actions · 2026-03-13T01:57:20Z

⚠️ Regressions detected on ubuntu-24.04 for commit `9ac61ed`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

mitchute · 2026-03-13T02:06:15Z

I ran git bisect. This started failing due to something in #11432, but I can't narrow it down to a specific commit. That all seems unrelated to the issue at hand anyway, so I'm guessing some cleanup in there exposed this issue.

rraustad · 2026-03-13T02:18:04Z

I'm still wrestling with the best logic for these scalable sizing inputs. I think I may have over specified the UnitarySystemModel_ConfirmUnitarySystemSizingTest unit test that exercises these scalable inputs thereby hiding the correct answer. If the code takes the wrong path it will just size with the data I used to back calculate the data used for the unit test (e.g., ends up using FinalZoneSizing data instead of the scaled value). I'll try to get this as sound as possible knowing that this area needs attention.

rraustad · 2026-03-13T02:32:20Z

I don't think 11432 is at all related. Changes to WindowManager should not affect component sizing.

mitchute · 2026-03-13T02:48:54Z

I don't think 11432 is at all related. Changes to WindowManager should not affect component sizing.

Agreed

rraustad · 2026-03-13T03:23:20Z

src/EnergyPlus/UnitarySystem.cc

                    SysCoolingFlow = CoolCapAtPeak * this->m_MaxCoolAirVolFlow;
                    state.dataSize->DataTotCapCurveIndex = 0;
+                    state.dataSize->DataFlowPerCoolingCapacity = this->m_MaxCoolAirVolFlow;
+                    state.dataSize->DataAutosizedCoolingCapacity = CoolCapAtPeak;


These are the globals used in the switch block for FlowPerCoolingCapacity, so set them and use that block in the switch on the final sizing pass. I still don't like things in the sizer functions, like heating used in a cooling function and using a std::max when sizing a fractional cooling air flow, but this is a good step forward. I do recall that these if conditionals were added just to be safe but it seems like over specifying code. See CoolingAirFlowSizing as an example.

github-actions · 2026-03-13T03:35:31Z

⚠️ Regressions detected on ubuntu-24.04 for commit `87b71ca`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

github-actions · 2026-03-13T03:37:52Z

⚠️ Regressions detected on macos-14 for commit `87b71ca`

Regression Summary

Audit: 5
EIO: 10
Table Big Diffs: 10
ERR: 2
ESO Big Diffs: 5
Table String Diffs: 5
MTR Big Diffs: 4

rraustad · 2026-03-13T13:30:38Z

OutdoorAirUnit has some new warnings and different component sizing so that file needs to be looked at before this can merge.

rraustad · 2026-03-13T15:11:21Z

The OutdoorAirUnit example file has CoilSystem:Cooling:DX objects in the outdoor air unit equipment list. This object is managed by UnitarySystem so the changes in this branch stomp on OA Unit sizing. I still think there is an issue with how the SizingMethod is handled in UnitarySystem but changes like this seem too sweeping to make this type of change at this time.

ZoneHVAC:OutdoorAirUnit:EquipmentList,
  Zone1OAEQLIST,           !- Name
  HeatExchanger:AirToAir:SensibleAndLatent,  !- Component 1 Object Type
  Zone1OAUHR,              !- Component 1 Name
  CoilSystem:Cooling:DX,   !- Component 2 Object Type
  DX Cooling Coil System 1,!- Component 2 Name
  Coil:Heating:Electric,   !- Component 3 Object Type
  Zone1OAUHeatingCoil;     !- Component 3 Name

The outdoor air unit uses these ZoneEqSizing variables which are used in the default for the switch in CoolingAirFlowSizing. To make this code change would require changing other zone equipment sizing methodology and that seems a little much at this point. I will close this PR and make another change that directly fixes the failing unit test.

    state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).CoolingAirFlow = true;
    state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).HeatingAirFlow = true;
    state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).CoolingAirVolFlow = thisOutAirUnit.OutAirVolFlow;
    state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).HeatingAirVolFlow = thisOutAirUnit.OutAirVolFlow;
    state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).OAVolFlow = thisOutAirUnit.OutAirVolFlow;

rraustad · 2026-03-13T15:21:12Z

@mitchute I'm not sure what to do with this branch since it tries to address an issue with UnitarySystem sizing. The scalable sizing inputs do not seem to be handled properly but this type of code change would take more time to flesh out. I think this PR should close but this issue does need to stay on the radar. PR #11464 directly corrects the unit test for now.

mitchute · 2026-03-13T16:30:03Z

Thanks @rraustad. That works. I will merge the fix on #11464, close this, and make a separate issue about the scalable sizing inputs pointing back to here for reference.

mitchute · 2026-03-13T16:38:27Z

Closing, but I will not delete the branch.

Step 1: See if this breaks anything

7bab8c1

rraustad added the Defect Includes code to repair a defect in EnergyPlus label Mar 12, 2026

Step 2 - Try, try, again

661bc95

rraustad changed the title ~~Step 1: See if this breaks anything~~ Correct SizingMethod variable initialization Mar 12, 2026

Step 3: Fix unit tests and add other SizingMethod logic

5fda760

rraustad commented Mar 13, 2026

View reviewed changes

Correct global used for SizingMethod reset

58e9dc8

Landing on this logic as better than stomping on user inputs

4fb0cf9

rraustad commented Mar 13, 2026

View reviewed changes

mitchute mentioned this pull request Mar 13, 2026

Correct Scalable Sizing Input Issues #11465

Open

mitchute closed this Mar 13, 2026

Conversation

rraustad commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Description of the purpose of this PR

Pull Request Author

Reviewer

Uh oh!

github-actions bot commented Mar 12, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 3552d2c

Uh oh!

github-actions bot commented Mar 12, 2026

⚠️ Regressions detected on macos-14 for commit 3552d2c

Uh oh!

github-actions bot commented Mar 12, 2026

⚠️ Regressions detected on macos-14 for commit c3581a8

Uh oh!

github-actions bot commented Mar 12, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit c3581a8

Uh oh!

rraustad Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

rraustad Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

rraustad Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 13, 2026

⚠️ Regressions detected on macos-14 for commit 7076cfa

Uh oh!

github-actions bot commented Mar 13, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 7076cfa

Uh oh!

rraustad commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 13, 2026

⚠️ Regressions detected on macos-14 for commit 9ac61ed

Uh oh!

github-actions bot commented Mar 13, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 9ac61ed

Uh oh!

mitchute commented Mar 13, 2026

Uh oh!

rraustad commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rraustad commented Mar 13, 2026

Uh oh!

mitchute commented Mar 13, 2026

Uh oh!

rraustad Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 13, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 87b71ca

Uh oh!

github-actions bot commented Mar 13, 2026

⚠️ Regressions detected on macos-14 for commit 87b71ca

Uh oh!

rraustad commented Mar 13, 2026

Uh oh!

rraustad commented Mar 13, 2026

Uh oh!

rraustad commented Mar 13, 2026

Uh oh!

mitchute commented Mar 13, 2026

Uh oh!

mitchute commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

rraustad commented Mar 12, 2026 •

edited

Loading

⚠️ Regressions detected on ubuntu-24.04 for commit `3552d2c`

⚠️ Regressions detected on macos-14 for commit `3552d2c`

⚠️ Regressions detected on macos-14 for commit `c3581a8`

⚠️ Regressions detected on ubuntu-24.04 for commit `c3581a8`

⚠️ Regressions detected on macos-14 for commit `7076cfa`

⚠️ Regressions detected on ubuntu-24.04 for commit `7076cfa`

rraustad commented Mar 13, 2026 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `9ac61ed`

⚠️ Regressions detected on ubuntu-24.04 for commit `9ac61ed`

rraustad commented Mar 13, 2026 •

edited

Loading

rraustad Mar 13, 2026 •

edited

Loading

⚠️ Regressions detected on ubuntu-24.04 for commit `87b71ca`

⚠️ Regressions detected on macos-14 for commit `87b71ca`