Baseclass for Openloop Storage Control Strategies#619
Open
elenya-grant wants to merge 4 commits intoNatLabRockies:developfrom
Open
Baseclass for Openloop Storage Control Strategies#619elenya-grant wants to merge 4 commits intoNatLabRockies:developfrom
elenya-grant wants to merge 4 commits intoNatLabRockies:developfrom
Conversation
21 tasks
kbrunik
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseclass for Openloop Storage Control Strategies
Introducing a baseclass for open-loop storage control strategies. This is intended to make the addition of new open-loop storage control strategies easier by defining the expected outputs of the storage controller.
Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 3: Related Issues
A step in issue #564
Section 4: Impacted Areas of the Software
Section 4.1: New Files
h2integrate/control/control_strategies/storage/openloop_storage_control_base.pyStorageOpenLoopControlBaseConfig: base configuration class for open-loop storage controlStorageOpenLoopControlBase: base class for open-loop storage controlSection 4.2: Modified Files
h2integrate/control/control_strategies/storage/demand_openloop_storage_controller.pyDemandOpenLoopStorageControllerConfig: updated to useStorageOpenLoopControlBaseConfigDemandOpenLoopStorageController: updated to useStorageOpenLoopControlBaseh2integrate/control/control_strategies/storage/simple_openloop_controller.pySimpleStorageOpenLoopControllerConfig: updated to useStorageOpenLoopControlBaseConfigSimpleStorageOpenLoopController:StorageOpenLoopControlBaseSection 5: Additional Supporting Information
Section 6: Test Results, if applicable