Limit size of simulation log file to prevent BSON size error - #840
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent MongoDB BSON document size failures (>16MB) by truncating the datapoint simulation log that is stored inline in DataPoint#sdp_log_file, and directing users to download the full log artifact instead. This improves robustness by avoiding silent failures that can prevent analyses from completing.
Changes:
- Introduces byte/line limits for inline
sdp_log_filecontent. - Replaces direct
File.read(...).linesusage with a helper (inline_log_lines) that reads only the tail of large logs. - Adds a user-facing truncation notice when logs are truncated (per the new helper behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| end | ||
| end | ||
|
|
||
| def inline_log_lines(log_path) |
Contributor
There was a problem hiding this comment.
Addressed in commit 0de42cf by adding focused specs for inline_log_lines covering both oversized log truncation and line-cap truncation, including assertions for the user-facing truncation note.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
brianlball
approved these changes
Jul 1, 2026
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error shows up with large simulation logs that BSON record is >16MB. This PR will truncate the log and make a note to download the file instead of saving it in the database. The failure was silent and causes the analysis to not finish. This should improve the robustness.