V25.2.0-IOFreeze: SiteWaterMainsTemperature's new fields#5477
Merged
Conversation
joseph-robertson
added
Pull Request - Ready for CI
26 tasks
Contributor
|
Thanks for this! |
Contributor
|
CI Results for 8e5857b:
|
joseph-robertson
marked this pull request as ready for review
October 10, 2025 18:43
jmarrec
approved these changes
Oct 20, 2025
Comment on lines
+1418
to
+1428
| N3, \field Temperature Multiplier | ||
| \note If calculation method is Schedule, this input field is ignored. | ||
| \type real | ||
| \units dimensionless | ||
| \required-field | ||
| \minimum 0 | ||
| N4; \field Temperature Offset | ||
| \note If calculation method is Schedule, this input field is ignored. | ||
| \type real | ||
| \units deltaC | ||
| \required-field |
Collaborator
There was a problem hiding this comment.
default 1 and default 0 (respectively) replaced by required-field: good
Comment on lines
+4648
to
+4650
| EXPECT_TRUE(swmt.isEmpty(4)); // Maximum Difference In Monthly Average Outdoor Air Temperatures | ||
| EXPECT_EQ(1.0, swmt.getDouble(5).get()); // Temperature Multiplier | ||
| EXPECT_EQ(0.0, swmt.getDouble(6).get()); // Temperature Offset |
| std::string update_3_7_0_to_3_8_0(const IdfFile& idf_3_7_0, const IddFileAndFactoryWrapper& idd_3_8_0); | ||
| std::string update_3_8_0_to_3_9_0(const IdfFile& idf_3_8_0, const IddFileAndFactoryWrapper& idd_3_9_0); | ||
| std::string update_3_9_0_to_3_10_0(const IdfFile& idf_3_9_0, const IddFileAndFactoryWrapper& idd_3_10_0); | ||
| std::string update_3_10_0_to_3_10_1(const IdfFile& idf_3_10_0, const IddFileAndFactoryWrapper& idd_3_10_1); |
Collaborator
There was a problem hiding this comment.
Should probably have done that on the v25.2.0-IOFreeze brnach, I hope this doesn't create conflicts too often.
Comment on lines
+9768
to
+9778
| auto iddObject = idd_3_10_1.getObject(iddname); | ||
| IdfObject newObject(iddObject.get()); | ||
|
|
||
| for (size_t i = 0; i < object.numFields(); ++i) { | ||
| if ((value = object.getString(i))) { | ||
| newObject.setString(i, value.get()); | ||
| } | ||
| } | ||
|
|
||
| newObject.setDouble(5, 1.0); | ||
| newObject.setDouble(6, 0.0); |
Comment on lines
+208
to
+211
| ok = setTemperatureMultiplier(1.0); | ||
| OS_ASSERT(ok); | ||
| ok = setTemperatureOffset(0.0); | ||
| OS_ASSERT(ok); |
Comment on lines
+62
to
+63
| siteWater.setTemperatureMultiplier(1.2); | ||
| siteWater.setTemperatureOffset(-0.5); |
Collaborator
There was a problem hiding this comment.
These technically return bool, so you should test that they return true. ANd test that siteWater.setTemperatureMultiplier(-10.0) fails.
Don't care that much, just being thorough though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.