Skip to content

Bump sphinx to 4.5.0#325

Merged
mdeceglie merged 2 commits into
developmentfrom
sphinx
May 17, 2022
Merged

Bump sphinx to 4.5.0#325
mdeceglie merged 2 commits into
developmentfrom
sphinx

Conversation

@kandersolar
Copy link
Copy Markdown
Member

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

Fixes an incompatibility with jinja2. Same as pvlib/pvlib-python#1435.

@kandersolar kandersolar added the dependencies Pull requests that update a dependency file label Apr 26, 2022
@kandersolar kandersolar marked this pull request as ready for review April 26, 2022 18:43
@kandersolar
Copy link
Copy Markdown
Member Author

The RTD PR build looks good to me, but would be good to get another set of eyes before merging

Copy link
Copy Markdown
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kanderso-nrel!

@mdeceglie mdeceglie merged commit f97a870 into development May 17, 2022
@mdeceglie mdeceglie deleted the sphinx branch May 17, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants