Skip to content

Make performance worse & Only Comment on Alert #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanielRN wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

Make performance worse & Only Comment on Alert #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/performance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
# Alert with a commit comment on possible performance regression
alert-threshold: 200%
comment-always: true
comment-on-alert: true
fail-on-alert: true
alert-comment-cc-users: '@${{ github.event.issue.user.login }}'
alert-comment-cc-users: '@${{ github.actor }}'
# Make a commit on `gh-pages` with benchmarks from previous step
auto-push: ${{ github.ref == 'refs/heads/mainline' }}
benchmark-data-dir-path: benchmarks
2 changes: 1 addition & 1 deletion core-2/tests/performance/benchmarks/test_benchmark_fibonacci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FIBONACCI_NUMBER = 3
FIBONACCI_NUMBER = 21


def test_core_2_fibonacci_recursive(benchmark):
Expand Down