vulkan: parallelize DSV4 Lightning Indexer prefill - #3
Open
Mushoz wants to merge 1 commit into
Open
Conversation
Assisted-by: Codex
Author
|
Whoops, accidentally posted while I was still writing the description. Will edit the PR. My apologies for the early post. Edit: Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same disclaimer as my previous PR :)
I have measured the following performance improvements:
209 -> 214 improvement at 32k
175 -> 190 improvement at 64k
As this PR improves the lightning indexer, the improvement will grow as context depth increases as the time spent on the lightning indexer increases with increasing context length. Micro benches confirm that the performance increase hold at least until 512k context length:
kvIt's a single commit this time.