latest.yml overwritten when building multiple architectures#145
Merged
Conversation
added 2 commits
December 18, 2024 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
publish:mac-armtopublish:mac-arm64the change was not reflected in thepublish:macscriptpublish:mac-arm&publish:mac-arm64in sequence. This caused thelatest-mac.ymlfile to be overwritten on the second run.This second point prevents the auto-update feature to detect new releases. I've changed the
publish:macscript to build for both architectures in a single process. This fixes the issue.Check out this issue on the electron-builder repo for more info.
Arguably the same should be done for the Windows & Linux build commands. Will add that if you are okay with this change @simonhamp