Implement PHP library inclusion#161
Conversation
SRWieZ
left a comment
There was a problem hiding this comment.
Great idea!
For reference, it's possible to include all libs with --with-suggested-libs.
https://static-php.dev/en/guide/deps-map.html
I'm okay with this approach that would help us keep the binaries small by maintaining the included libs ourselves.
I hope Imagick will be supported on Windows soon because it's so much better than GD.
Yeah, I should've made it clear that this was my thinking. I much prefer explicitly defining what we want as opposed to something "guessing" what we'd like, based on suggestions. Totally happy with either approach but this was just a personal preference. Thanks for the input :D |
|
Perfect. Thanks Pete!
Just a question, maybe for another PR. If binary size is important we might want to compress them. Spc has this built-in but it is only supported on windows & Linux. From the docs:
|
|
Simon only included functionalities that are supported on all platforms. So I think it's a no-go. And I'm not sure, but in our context, it may slow down every request. |
backport of NativePHP#161
Closes https://github.com/NativePHP/laravel/issues/460