Skip to content
Draft
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a96d750
chore: Use jint for Java object ID everywhere
ptomato Apr 28, 2023
9c53587
chore: Avoid shadowing variable
ptomato May 8, 2023
f2d6cac
chore: Remove dead code from ObjectManager
ptomato May 8, 2023
29311b2
feat: Remove markingMode
ptomato May 8, 2023
8d5f8f5
chore: Remove useGlobalRefs
ptomato May 10, 2023
4ec8502
chore: Init ObjectManager::m_isolate in Init()
ptomato May 16, 2023
d7a590d
chore: Initialize ObjectManager in one phase
ptomato May 16, 2023
489100c
chore: Make some methods static
ptomato May 17, 2023
cc6fd5d
chore: Store wrapper object template instead of ctor function template
ptomato May 18, 2023
917422f
fix: NativeScript include directories in cmake file
ptomato Aug 30, 2023
e8e9dec
fix: passing wrong arguments to NativeScriptException ctor
ptomato Aug 29, 2023
016c077
fix: Populate keywords set during static initialization
ptomato Aug 30, 2023
e87074a
fix: init NativeScriptException earlier
ptomato Aug 29, 2023
e284c07
fix: move GetClassName out of ObjectManager
ptomato Aug 29, 2023
91ca870
fix: Safety check on clearing dex cache
ptomato Aug 30, 2023
c58d3ff
chore: Switch from CreationContext() to GetCreationContextChecked()
ptomato Feb 10, 2023
492dadc
chore: Set V8 flags before initializing V8
ptomato Apr 28, 2023
9a96029
chore: Use CPPGC-compatible platform
ptomato May 17, 2023
a11a490
chore: Remove unused V8 inspector sources
ptomato May 9, 2023
34d2786
chore: Remove duplicate code
ptomato May 25, 2023
18f90c4
chore: Make MetadataNode::tryGetExtensionMethodCallbackData more effi…
ptomato May 30, 2023
1843dd2
chore: Remove ObjectManager dead code
ptomato Aug 25, 2023
25338bf
chore: Avoid copy in MetadataNode::IsJavascriptKeyword
ptomato Aug 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: init NativeScriptException earlier
Unlikely, but the ArgConverter calls at the beginning of Runtime::Init()
could theoretically throw a Java exception, in which case they'd be
wrapped into a C++ NativeScriptException and then re-thrown to Java. For
that to work, NativeScriptException has to be initialized.
  • Loading branch information
ptomato authored and edusperoni committed Sep 22, 2023
commit e87074a955abed5abf0a51e5e177bb7fba81f2ca
2 changes: 1 addition & 1 deletion test-app/runtime/src/main/cpp/Runtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ void Runtime::Init(JNIEnv* _env, jobject obj, int runtimeId, jstring filesPath,

void Runtime::Init(JNIEnv* env, jstring filesPath, jstring nativeLibDir, bool verboseLoggingEnabled, bool isDebuggable, jstring packageName, jobjectArray args, jstring callingDir, int maxLogcatObjectSize, bool forceLog) {
LogEnabled = verboseLoggingEnabled;
NativeScriptException::Init();

auto filesRoot = ArgConverter::jstringToString(filesPath);
auto nativeLibDirStr = ArgConverter::jstringToString(nativeLibDir);
Expand All @@ -196,7 +197,6 @@ void Runtime::Init(JNIEnv* env, jstring filesPath, jstring nativeLibDir, bool ve

auto profilerOutputDirStr = ArgConverter::jstringToString(profilerOutputDir);

NativeScriptException::Init();
m_isolate = PrepareV8Runtime(filesRoot, nativeLibDirStr, packageNameStr, isDebuggable, callingDirStr, profilerOutputDirStr, maxLogcatObjectSize, forceLog);
}

Expand Down