Skip to content

feat: support import.meta.hot.data for persistent objects across hmr updates #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NathanWalker wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: support import.meta.hot.data for persistent objects across hmr updates #329

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e391ab
feat: support import.meta.hot.data for persistent objects across hmr …
NathanWalker Dec 15, 2025
51ae7ca
chore: log cleanup
NathanWalker Dec 18, 2025
7ca43ef
chore: unit tests
NathanWalker Dec 18, 2025
15fc103
feat: improve unit test reports on esm loader tests
NathanWalker Dec 18, 2025
4a87566
chore: unit tests
NathanWalker Dec 18, 2025
c0723d5
chore: unit tests
NathanWalker Dec 18, 2025
fb7833b
chore: unit tests missing impl
NathanWalker Dec 18, 2025
7dff8ee
feat: Blob URL support
NathanWalker Jan 4, 2026
86a42f0
feat: support for meta.hot.on, meta.hot.send and custom event listeners
NathanWalker Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: improve unit test reports on esm loader tests
  • Loading branch information
@NathanWalker
NathanWalker committed Dec 18, 2025
commit 15fc103601cd6c99383d763794b20b44bfbbb441
71 changes: 53 additions & 18 deletions TestRunner/app/tests/HttpEsmLoaderTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,47 @@

describe("HTTP ESM Loader", function() {

function formatError(e) {
try {
if (!e) return "(no error)";
if (e instanceof Error) return e.message;
if (typeof e === "string") return e;
if (e && typeof e.message === "string") return e.message;
return JSON.stringify(e);
} catch (_) {
return String(e);
}
}

function withTimeout(promise, ms, label) {
return new Promise(function(resolve, reject) {
var timer = setTimeout(function() {
reject(new Error("Timeout after " + ms + "ms" + (label ? ": " + label : "")));
}, ms);

promise.then(function(value) {
clearTimeout(timer);
resolve(value);
}).catch(function(err) {
clearTimeout(timer);
reject(err);
});
});
}

function getHostOrigin() {
try {
var reportUrl = NSProcessInfo.processInfo.environment.objectForKey("REPORT_BASEURL");
if (!reportUrl) return null;
// REPORT_BASEURL is like: http://[::1]:63846/junit_report
return new URL(String(reportUrl)).origin;
// In CI the host may be bound to IPv6 loopback; normalize to IPv4 loopback to avoid
// simulator connectivity issues/timeouts when importing HTTP modules.
var u = new URL(String(reportUrl));
var host = String(u.hostname);
if (host === "::1" || host === "localhost") {
u.hostname = "127.0.0.1";
}
return u.origin;
} catch (e) {
return null;
}
Expand Down Expand Up @@ -206,7 +241,7 @@ describe("HTTP ESM Loader", function() {
? [origin + "/esm/hmr/hot-data-ext.mjs", origin + "/esm/hmr/hot-data-ext.js"]
: ["~/tests/esm/hmr/hot-data-ext.mjs"];

Promise.all(specs.map(function (s) { return import(s); }))
withTimeout(Promise.all(specs.map(function (s) { return import(s); })), 5000, "import hot-data test modules")
.then(function (mods) {
var mjs = mods[0];
var apiMjs = mjs && typeof mjs.testHotApi === "function" ? mjs.testHotApi() : null;
Expand All @@ -227,7 +262,7 @@ describe("HTTP ESM Loader", function() {
done();
})
.catch(function (error) {
fail("Expected hot-data test modules to import: " + (error && error.message ? error.message : String(error)));
fail(new Error("Expected hot-data test modules to import: " + formatError(error)));
done();
});
});
Expand All @@ -240,10 +275,10 @@ describe("HTTP ESM Loader", function() {
return;
}

Promise.all([
withTimeout(Promise.all([
import(origin + "/esm/hmr/hot-data-ext.mjs"),
import(origin + "/esm/hmr/hot-data-ext.js"),
])
]), 5000, "import .mjs/.js hot-data modules")
.then(function (mods) {
var mjs = mods[0];
var js = mods[1];
Expand All @@ -270,7 +305,7 @@ describe("HTTP ESM Loader", function() {
done();
})
.catch(function (error) {
fail("Expected hot.data sharing assertions to succeed: " + (error && error.message ? error.message : String(error)));
fail(new Error("Expected hot.data sharing assertions to succeed: " + formatError(error)));
done();
});
});
Expand All @@ -288,17 +323,17 @@ describe("HTTP ESM Loader", function() {
var u1 = origin + "/esm/query.mjs?v=1";
var u2 = origin + "/esm/query.mjs?v=2";

import(u1)
withTimeout(import(u1), 5000, "import " + u1)
.then(function (m1) {
return import(u2).then(function (m2) {
return withTimeout(import(u2), 5000, "import " + u2).then(function (m2) {
expect(m1.query).toContain("v=1");
expect(m2.query).toContain("v=2");
expect(m1.query).not.toBe(m2.query);
done();
});
})
.catch(function (error) {
fail("Expected host HTTP module imports to succeed: " + (error && error.message ? error.message : String(error)));
fail(new Error("Expected host HTTP module imports to succeed: " + formatError(error)));
done();
});
});
Expand All @@ -314,9 +349,9 @@ describe("HTTP ESM Loader", function() {
var u1 = origin + "/ns/m/query.mjs?v=1";
var u2 = origin + "/ns/m/query.mjs?v=2";

import(u1)
withTimeout(import(u1), 5000, "import " + u1)
.then(function (m1) {
return import(u2).then(function (m2) {
return withTimeout(import(u2), 5000, "import " + u2).then(function (m2) {
// With cache-buster normalization, both imports should map to the same cache key.
// The second import should reuse the first evaluated module.
expect(m2.evaluatedAt).toBe(m1.evaluatedAt);
Expand All @@ -325,7 +360,7 @@ describe("HTTP ESM Loader", function() {
});
})
.catch(function (error) {
fail("Expected dev-endpoint HTTP module imports to succeed: " + (error && error.message ? error.message : String(error)));
fail(new Error("Expected dev-endpoint HTTP module imports to succeed: " + formatError(error)));
done();
});
});
Expand All @@ -341,16 +376,16 @@ describe("HTTP ESM Loader", function() {
var u1 = origin + "/ns/m/query.mjs?b=2&a=1";
var u2 = origin + "/ns/m/query.mjs?a=1&b=2";

import(u1)
withTimeout(import(u1), 5000, "import " + u1)
.then(function (m1) {
return import(u2).then(function (m2) {
return withTimeout(import(u2), 5000, "import " + u2).then(function (m2) {
expect(m2.evaluatedAt).toBe(m1.evaluatedAt);
expect(m2.query).toBe(m1.query);
done();
});
})
.catch(function (error) {
fail("Expected dev-endpoint HTTP module imports to succeed: " + (error && error.message ? error.message : String(error)));
fail(new Error("Expected dev-endpoint HTTP module imports to succeed: " + formatError(error)));
done();
});
});
Expand All @@ -366,15 +401,15 @@ describe("HTTP ESM Loader", function() {
var u1 = origin + "/esm/query.mjs#one";
var u2 = origin + "/esm/query.mjs#two";

import(u1)
withTimeout(import(u1), 5000, "import " + u1)
.then(function (m1) {
return import(u2).then(function (m2) {
return withTimeout(import(u2), 5000, "import " + u2).then(function (m2) {
expect(m2.evaluatedAt).toBe(m1.evaluatedAt);
done();
});
})
.catch(function (error) {
fail("Expected fragment HTTP module imports to succeed: " + (error && error.message ? error.message : String(error)));
fail(new Error("Expected fragment HTTP module imports to succeed: " + formatError(error)));
done();
});
});
Expand Down
Loading