Skip to content

fix: platform update/clean commands may fail with Java 10 #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosen-vladimirov merged 5 commits into from
May 28, 2018
Merged

fix: platform update/clean commands may fail with Java 10 #3626

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d694a25
fix: Validate environment based on specified runtime version
rosen-vladimirov May 28, 2018
e6979ef
chore: Update version of natiescript-doctor to current rc
rosen-vladimirov May 28, 2018
5bc7a58
chore: Fix unit-tests
rosen-vladimirov May 28, 2018
2a7a252
chore: Update to latest common lib
rosen-vladimirov May 28, 2018
4f98f8b
chore: Update nativescript-doctor to 1.2.0
rosen-vladimirov May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Fix unit-tests
  • Loading branch information
@rosen-vladimirov
rosen-vladimirov committed May 28, 2018
commit 5bc7a58512a81cea29603e0c1dca515af9b8b667
3 changes: 3 additions & 0 deletions test/platform-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ function createTestInjector() {
getPlaygroundInfo: () => Promise.resolve(null)
});
testInjector.register("filesHashService", {});
testInjector.register("platformEnvironmentRequirements", {
checkEnvironmentRequirements: async (platform?: string, projectDir?: string, runtimeVersion?: string): Promise<boolean> => true
});

return testInjector;
}
Expand Down