Skip to content

fix(clean) report failures to remove item #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rigor789 merged 6 commits into from
Oct 27, 2021
Merged

fix(clean) report failures to remove item #5601

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b0ae3e9
fix(clean) report failures to remove
jcassidyav Oct 27, 2021
097b7c9
Rename variable
jcassidyav Oct 27, 2021
4017a32
rename variable
jcassidyav Oct 27, 2021
6125226
use let
jcassidyav Oct 27, 2021
b215245
Rename varialbe to success for clarity.
jcassidyav Oct 27, 2021
1534842
Rename varialbe to success for clarity.
jcassidyav Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename varialbe to success for clarity.
  • Loading branch information
@jcassidyav
jcassidyav committed Oct 27, 2021
commit b215245b386c3ed7875c37bbe95291ae5a8e8061
6 changes: 3 additions & 3 deletions lib/services/project-cleanup-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class ProjectCleanupService implements IProjectCleanupService {
}

public async clean(pathsToClean: string[]): Promise<boolean> {
let result = true;
let success = true;
for (const pathToClean of pathsToClean) {
const isCleaned = await this.cleanPath(pathToClean).catch((error) => {
this.$logger.trace(
Expand All @@ -25,9 +25,9 @@ export class ProjectCleanupService implements IProjectCleanupService {
);
return false;
});
result = result && isCleaned;
success = success && isCleaned;
}
return result;
return success;
}

public async cleanPath(pathToClean: string): Promise<boolean> {
Expand Down