Skip to content

fix: prevent error when adding framework from build product dir #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farfromrefug wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent error when adding framework from build product dir #20

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d085a
fix: prevent error when adding framework from build product dir
farfromrefug Jan 23, 2026
56fa2cf
chore: also keep group
farfromrefug Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: prevent error when adding framework from build product dir 
Retain the path property for later use after explicit file type assignment.
  • Loading branch information
@farfromrefug
farfromrefug authored Jan 23, 2026
commit d9d085a8114f87a81e981d3421204784913a6b17
5 changes: 3 additions & 2 deletions lib/pbxFile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ function pbxFile(filepath, opt) {
if (opt.explicitFileType) {
this.explicitFileType = opt.explicitFileType;
this.basename = this.basename + '.' + defaultExtension(this);
delete this.path;
// dont delete path as it is used after
// delete this.path;
delete this.lastKnownFileType;
delete this.group;
delete this.defaultEncoding;
Expand All @@ -155,4 +156,4 @@ function pbxFile(filepath, opt) {
}
}

module.exports = pbxFile;
module.exports = pbxFile;