[mkdocs] docs: apply review comments (websockets) - #932
Merged
segfaultxavi merged 3 commits intoJul 9, 2026
Conversation
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
force-pushed
the
docs-revision-websockets
branch
2 times, most recently
from
July 7, 2026 14:40
bbeec0e to
85c8f21
Compare
zero4862
force-pushed
the
docs-revision-websockets
branch
from
July 7, 2026 14:55
85c8f21 to
d40178c
Compare
zero4862
commented
Jul 7, 2026
zero4862
commented
Jul 7, 2026
zero4862
marked this pull request as ready for review
July 7, 2026 15:06
zero4862
commented
Jul 7, 2026
Jaguar0625
approved these changes
Jul 7, 2026
segfaultxavi
requested changes
Jul 8, 2026
segfaultxavi
left a comment
segfaultxavi
left a comment
Contributor
There was a problem hiding this comment.
Markdown requires code fences to have blank lines around them. MkDocs is not picky about it, but it triggers my IDE's Markdown linter :)
Also, the style is inconsistent in the file, so please add the blank lines.
zero4862
force-pushed
the
docs-revision-websockets
branch
from
July 8, 2026 17:51
13165b2 to
4b45051
Compare
zero4862
force-pushed
the
docs-revision-websockets
branch
from
July 8, 2026 17:55
a14e7a8 to
5180827
Compare
segfaultxavi
pushed a commit
that referenced
this pull request
Jul 9, 2026
Address review comments from @Jaguar0625 on July 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review comments from @Jaguar0625 on July 2.