Skip to content

[mkdocs] fix: apply mosaic review comments - #941

Merged
segfaultxavi merged 2 commits into
NemProject:new-docsfrom
zero4862:review-comments-mosaics
Jul 22, 2026
Merged

[mkdocs] fix: apply mosaic review comments#941
segfaultxavi merged 2 commits into
NemProject:new-docsfrom
zero4862:review-comments-mosaics

Conversation

@zero4862

@zero4862 zero4862 commented Jul 21, 2026

Copy link
Copy Markdown

Address review comments from @Jaguar0625 on July 16.

@zero4862
zero4862 force-pushed the review-comments-mosaics branch from e472d86 to 711c9c5 Compare July 21, 2026 15:31
@zero4862
zero4862 requested a review from Jaguar0625 July 21, 2026 15:31
@zero4862
zero4862 marked this pull request as ready for review July 21, 2026 15:31

@Jaguar0625 Jaguar0625 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Comment thread mkdocs/pages/en/devbook/mosaics/modify-mosaic-definition.md Outdated
@zero4862
zero4862 requested a review from segfaultxavi July 21, 2026 16:56

@Jaguar0625 Jaguar0625 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@segfaultxavi segfaultxavi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions. Also, much cleaner using NetworkTimestamp.addHours() 馃憤

@segfaultxavi
segfaultxavi merged commit 5d51480 into NemProject:new-docs Jul 22, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants